[x] Do these changes introduce new tools, command line arguments, or configuration file options? [Sort of]
If yes, please describe:
Adds support to Stat-Analysis for the following combination of job command options:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes:
Please see testing described in this issue comment.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes. You're welcome to rerun my testing on seneca, although there will likely be permission issues.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
None needed. The existing documentation would imply this already works.
[x] Do these changes include sufficient testing updates? [No]
None really needed. I decided not to add new tests to handle this edge case. If we were to test all options at this level of detail, we'd be testing too much.
[x] Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update TruthMETplus issue to describe them.
[x] Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
I hope not. If this PR fails the SonarQube scan, please do not approve.
[x] Please complete this pull request review by [Fri 5/17/24].
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[x] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[x] Close the linked issue and delete your feature or bugfix branch from GitHub.
Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [Sort of] If yes, please describe: Adds support to Stat-Analysis for the following combination of job command options:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes: Please see testing described in this issue comment.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Review code changes. You're welcome to rerun my testing on seneca, although there will likely be permission issues.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No] None needed. The existing documentation would imply this already works.
[x] Do these changes include sufficient testing updates? [No] None really needed. I decided not to add new tests to handle this edge case. If we were to test all options at this level of detail, we'd be testing too much.
[x] Will this PR result in changes to the MET test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No] If yes, create a new Update Truth METplus issue to describe them.
[x] Do these changes introduce new SonarQube findings? [No] If yes, please describe: I hope not. If this PR fails the SonarQube scan, please do not approve.
[x] Please complete this pull request review by [Fri 5/17/24].
Pull Request Checklist
See the METplus Workflow for details.