Bugfix #2902 main_v11.1 pb2nc_pbl

[JohnHalleyGotway]

Expected Differences

• [x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  If yes, please describe:
  

• [x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  If yes, please describe:
  

Pull Request Testing

• [x] Describe testing already performed for these changes:
  Compiled and tested this bugfix branch code in seneca:/d1/projects/METplus/discussions/2599/MET. Ran the test_pb2nc.sh script to run PB2NC 10 times and confirm that we get the same result in each.

In addition, tested using main_v11.1 from the nightly build with -v 10. For station 71722 I see the following log messages:

DEBUG 8: compute_pbl() input to calpbl_ (buffer): index, P, Q, T, Z, U, V
DEBUG 8: compute_pbl()   0   15607511481187303424.00000 0.00000 -3152171068026237978910130176.00000 -0.00000 6.50000 -1.70000
DEBUG 8: compute_pbl()   1   93960.00000 0.00659 286.96384 610.00000 6.50000 -1.70000
DEBUG 8: compute_pbl()   2   97400.00000 0.00840 289.29169 305.00000 2.00000 0.70000
DEBUG 8: compute_pbl()   3   98700.00000 0.00906 290.14999 192.00000 -9999.00000 -9999.00000
DEBUG 7:  hpbl: 610, obs_arr[4]: 418   lat: 46.29999924, lon: -76, elv: 192 20190615_000000 ADPUPA 71722

Note the obvious problem with the pressure and temperature values for record index 0. This is the result of the bug.

Testing with this bugfix branch, I get the following corrected log messages which are an accurate reversal of the input pressure level values:

DEBUG 8: compute_pbl() input to calpbl_ (buffer): index, P, Q, T, Z, U, V
DEBUG 8: compute_pbl()   0   92500.00000 0.00580 285.95001 735.00000 6.50000 -1.70000
DEBUG 8: compute_pbl()   1   93960.00000 0.00659 286.96384 610.00000 6.50000 -1.70000
DEBUG 8: compute_pbl()   2   97400.00000 0.00840 289.29169 305.00000 2.00000 0.70000
DEBUG 8: compute_pbl()   3   98700.00000 0.00906 290.14999 192.00000 -9999.00000 -9999.00000
DEBUG 7:  hpbl: 735, obs_arr[4]: 543   lat: 46.29999924, lon: -76, elv: 192 20190615_000000 ADPUPA 71722

• [x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  No additional testing needed.

• [x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] None needed.

• [x] Do these changes include sufficient testing updates? [Yes or No] None needed.

• [x] Will this PR result in changes to the MET test suite? [Yes]
  If yes, describe the new output and/or changes to the existing output:
  Yes, I do expect the derived PBL output computed by pb2nc for main_v11.1 to be impacted by this fix.

• [x] Will this PR result in changes to existing METplus Use Cases? [Yes]
  If yes, create a new Update Truth METplus issue to describe them. Yes, I do expect the derived PBL output for METplus use cases to be impacted by this fix. However, no METplus regression test is automatically triggered by fixes in the main_v11.1 branch.

• [x] Do these changes introduce new SonarQube findings? [No]
  If yes, please describe: I do not expect them to, and we should fix SonarQube in develop, not main_vX.Y branches.

• [x] Please complete this pull request review by [Fri 5/24/24].
  

Pull Request Checklist

See the METplus Workflow for details.

• [x] Review the source issue metadata (required labels, projects, and milestone).
• [x] Complete the PR definition above.
• [x] Ensure the PR title matches the feature or bugfix branch name.
• [x] Define the PR metadata, as permissions allow. Select: Reviewer(s) and Development issue Select: Milestone as the version that will include these changes Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• [x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.