[ ] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]
If yes, please describe:
[ ] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes or No]
If yes, please describe:
Pull Request Testing
[ ] Describe testing already performed for these changes:
[ ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
[ ] Do these changes include sufficient testing updates? [Yes or No]
[ ] Will this PR result in changes to the MET test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
[ ] Will this PR result in changes to existing METplus Use Cases? [Yes or No]
If yes, create a new Update TruthMETplus issue to describe them.
[ ] Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
[ ] Please complete this pull request review by [Fill in date].
[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Expected Differences
No difference (no failures with unit test)
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes:
Ran the nightly build
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
N/A
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
[x] Do these changes include sufficient testing updates? [No]
[x] Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update TruthMETplus issue to describe them.
[x] Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
[x] Please complete this pull request review by 6/07/2024].
[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
hsoh-u
commented
1 month ago
Expected Differences
No difference (no failures with unit test)
[ ] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No] If yes, please describe:
[ ] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes or No] If yes, please describe:
Pull Request Testing
[ ] Describe testing already performed for these changes:
[ ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
[ ] Do these changes include sufficient testing updates? [Yes or No]
[ ] Will this PR result in changes to the MET test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output:
[ ] Will this PR result in changes to existing METplus Use Cases? [Yes or No] If yes, create a new Update Truth METplus issue to describe them.
[ ] Do these changes introduce new SonarQube findings? [Yes or No] If yes, please describe:
[ ] Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Expected Differences
No difference (no failures with unit test)
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No] If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
Ran the nightly build
N/A
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
[x] Do these changes include sufficient testing updates? [No]
[x] Will this PR result in changes to the MET test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No] If yes, create a new Update Truth METplus issue to describe them.
[x] Do these changes introduce new SonarQube findings? [No] If yes, please describe:
[x] Please complete this pull request review by 6/07/2024].
Pull Request Checklist
See the METplus Workflow for details.