Closed JohnHalleyGotway closed 2 weeks ago
Here are the differences flagged in the GHA testing.yml
workflow:
COMPARING tc_stat/ALAL2010_AHWI_ri.tcst
file1: /data/output/met_test_truth/tc_stat/ALAL2010_AHWI_ri.tcst
file2: /data/output/met_test_output/tc_stat/ALAL2010_AHWI_ri.tcst
ERROR: header information mismatch in column DESC
SUMMARY for non-bootstrap numerical values
# comparisons: 0
# differences: 0
ERROR: failed tests for TCST_TCMPR: hdr
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
COMPARING tc_stat/ALAL2010_AHWI_rw.tcst
file1: /data/output/met_test_truth/tc_stat/ALAL2010_AHWI_rw.tcst
file2: /data/output/met_test_output/tc_stat/ALAL2010_AHWI_rw.tcst
ERROR: header information mismatch in column DESC
SUMMARY for non-bootstrap numerical values
# comparisons: 0
# differences: 0
ERROR: failed tests for TCST_TCMPR: hdr
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
COMPARING tc_stat/ALAL2010_rirw.stat
file1: /data/output/met_test_truth/tc_stat/ALAL2010_rirw.stat
file2: /data/output/met_test_output/tc_stat/ALAL2010_rirw.stat
ERROR: header information mismatch in column DESC
ERROR: header information mismatch in column DESC
SUMMARY for non-bootstrap numerical values
# comparisons: 0
# differences: 0
ERROR: failed tests for CTC: hdr
ERROR: failed tests for CTS: hdr
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
COMPARING tc_stat/PROBRIRW_filter_ee.tcst
file1: /data/output/met_test_truth/tc_stat/PROBRIRW_filter_ee.tcst
file2: /data/output/met_test_output/tc_stat/PROBRIRW_filter_ee.tcst
ERROR: header information mismatch in column DESC
ERROR: header information mismatch in column DESC
I manually inspected the diffs in these files and confirmed that they're all intended based on the -set_hdr
options I added to the existing TC-Stat jobs.
These changes enhance TC-Stat to support the
-set_hdr
job command option. This is already supported by Stat-Analysis but needs to be added for TC-Stat. There are many more files modified here than I originally intended.This is now supported for both the
-job filter
and-job rirw
job types. While implementing this for TC-Stat, I decided to addStatHdrColumns::apply_set_hdr_opts()
andTCHdrColumns::apply_set_hdr_opts()
member functions. With those in place, I updated Stat-Analysis and the GSI tools to call that common library functionality. This should help with providing and maintaining consistent functionality across tools.I had to make some mods to core libraries to support these changes.
Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes] If yes, please describe: The
-set_hdr COL_NAME COL_VALUE
is now supported for TC-Stat.[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes: Manually tested on my machine.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Review code changes. Review doc updates. Make sure all tests pass, except for the modified TC-Stat output.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] Updated the TC-Stat chapter.
[x] Do these changes include sufficient testing updates? [Yes] Modified existing TC-Stat job to exercise this new
-set_hdr
option.[x] Will this PR result in changes to the MET test suite? [Yes] If yes, describe the new output and/or changes to the existing output: Modifies output of existing TC-Stat output.
[x] Will this PR result in changes to existing METplus Use Cases? [No] If yes, create a new Update Truth METplus issue to describe them. Should produce the same output for all METplus Use Cases. This just adds a new job option.
[x] Do these changes introduce new SonarQube findings? [No] If yes, please describe: Please do not approve if SonarQube findings are increased.
[x] Please complete this pull request review by [Tues 6/18/24].
Pull Request Checklist
See the METplus Workflow for details.