These are the same set of changes as PR #2917 but for the develop branch rather than main_v11.1. Note however, that this also modifies the existing EnsembleStatConfig_climo file to exercise the logic discussed in the original dtcenter/METplus#2536 discussion.
Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes:
Compiled in seneca:/d1/personal/johnhg/MET/MET_development/MET-bugfix_2856_develop_ens_climo and tested with script /d1/projects/METplus/discussions/2536/es_example/run_es_develop_fix.sh to confirm that applying the same changes from PR #2917 also work for the develop branch.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review this at the same time as #2917 since the changes are the same.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
[x] Do these changes include sufficient testing updates? [Yes]
Modified EnsembleConfigConfig_climo configuration to add more output from the existing run of ensemble_stat.
[x] Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Modifies the output in these files: test_output/climatology_1.0deg/ensemble_stat_NCEP_1.0DEG_20120410_120000V*.
[x] Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update TruthMETplus issue to describe them.
I do not expect any changes.
[x] Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
[x] Please complete this pull request review by [Thurs 6/20/24].
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
These are the same set of changes as PR #2917 but for the develop branch rather than main_v11.1. Note however, that this also modifies the existing
EnsembleStatConfig_climofile to exercise the logic discussed in the original dtcenter/METplus#2536 discussion.Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No] If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes: Compiled in
seneca:/d1/personal/johnhg/MET/MET_development/MET-bugfix_2856_develop_ens_climoand tested with script/d1/projects/METplus/discussions/2536/es_example/run_es_develop_fix.shto confirm that applying the same changes from PR #2917 also work for the develop branch.[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Please review this at the same time as #2917 since the changes are the same.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
[x] Do these changes include sufficient testing updates? [Yes] Modified
EnsembleConfigConfig_climoconfiguration to add more output from the existing run of ensemble_stat.[x] Will this PR result in changes to the MET test suite? [Yes] If yes, describe the new output and/or changes to the existing output: Modifies the output in these files:
test_output/climatology_1.0deg/ensemble_stat_NCEP_1.0DEG_20120410_120000V*.[x] Will this PR result in changes to existing METplus Use Cases? [No] If yes, create a new Update Truth METplus issue to describe them. I do not expect any changes.
[x] Do these changes introduce new SonarQube findings? [No] If yes, please describe:
[x] Please complete this pull request review by [Thurs 6/20/24].
Pull Request Checklist
See the METplus Workflow for details.