dtcenter / MET

Model Evaluation Tools
https://dtcenter.org/community-code/model-evaluation-tools-met
Apache License 2.0
77 stars 24 forks source link

Bugfix #2841 main_v11.1 tang_rad_winds #2920

Closed JohnHalleyGotway closed 3 months ago

JohnHalleyGotway commented 3 months ago

Expected Differences

Please review this at the same time as PR #2921, to fix this in the develop branch.

Pull Request Testing

All of the gridded NetCDF differences show this 90 shift to the right.

I also reran the commands listed in this issue comment, using this the PR version of tc_rmw (/d1/projects/MET/MET_pull_requests/met-11.1.1/MET-bugfix_2841_main_v11.1_tang_rad_winds/bin/tc_rmw). Here's the graphics to compare:

From HAFS plotting script: IDALIA10L 2023082918 HFSA storm azimuth_wind f000

And cross-sections of VR and VT from METplotpy: tcrmw_cross_section_VR tcrmw_cross_section_VT

Note that the differences flagged in this GHA run are confined to the output from TC-RMW, RMW-Analysis, and TC-Diag, as expected.

Pull Request Checklist

See the METplus Workflow for details.

JohnHalleyGotway commented 3 months ago

I was able to modify the code to change the azimuths from rotating counterclockwise (from due east) to clockwise. I reran the Idalia test case in seneca:/d1/projects/MET/MET_issues/bugfix_2841. Here's the impact on the computation of radial wind and tangential wind. Old CCW on the left and new CW on the right:

Screen Shot 2024-06-22 at 10 04 33 AM Screen Shot 2024-06-22 at 10 05 04 AM

The new version certainly has more structure, which hopefully is a good thing.