Closed JohnHalleyGotway closed 3 months ago
I was able to modify the code to change the azimuths from rotating counterclockwise (from due east) to clockwise. I reran the Idalia test case in seneca:/d1/projects/MET/MET_issues/bugfix_2841. Here's the impact on the computation of radial wind and tangential wind. Old CCW on the left and new CW on the right:
The new version certainly has more structure, which hopefully is a good thing.
Expected Differences
Please review this at the same time as PR #2921, to fix this in the
develop
branch.[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No] If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
This ncview comparison of TC-RMW output for TMP/P500 shows that the diffs are caused by the intended 90 degree phase shift to the right.
All of the gridded NetCDF differences show this 90 shift to the right.
I also reran the commands listed in this issue comment, using this the PR version of tc_rmw (
/d1/projects/MET/MET_pull_requests/met-11.1.1/MET-bugfix_2841_main_v11.1_tang_rad_winds/bin/tc_rmw
). Here's the graphics to compare:From HAFS plotting script:
And cross-sections of VR and VT from METplotpy:
/d1/projects/MET/MET_pull_requests/met-11.1.1/MET-bugfix_2841_main_v11.1_tang_rad_winds
Note that the differences flagged in this GHA run are confined to the output from TC-RMW, RMW-Analysis, and TC-Diag, as expected.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No] I updated the User's Guide for the MET-12.0.0 release, not this MET-11.1.1 bugfix release.
[x] Do these changes include sufficient testing updates? [Yes] No additional tests are needed.
[x] Will this PR result in changes to the MET test suite? [Yes] If yes, describe the new output and/or changes to the existing output: All output from TC-RMW and TC-Diag will be modified.
[x] Will this PR result in changes to existing METplus Use Cases? [Yes] If yes, create a new Update Truth METplus issue to describe them. Any use cases that run TC-RMW and TC-Diag will be modified. However, METplus does NOT run tests using
main_v11.1
so no diffs will be flagged.[x] Do these changes introduce new SonarQube findings? [???] If yes, please describe: Unknown
[x] Please complete this pull request review by [Fri 6/21/24]. This needs to be included in the MET-11.1.1 bugfix release, slated for Friday 6/21/24.
Pull Request Checklist
See the METplus Workflow for details.