[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes:
grid_stat:
The first run is using the configuration.
The second run is using the environment variable.
The third command is using both (to check the precedence)
- [x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:</br>
The build is available at seneca:/d1/personal/hsoh/git/pull_request/MET_feature_2601_seeps_climo_config
- [x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? **[Yes]**
- [x] Do these changes include sufficient testing updates? **[Yes]**
The unit test ism changed to muse the configuration file instead of the environment variable. MET_SEEPS_GRID_CLIMO_NAME.
- [x] Will this PR result in changes to the MET test suite? **[No]**</br>
If **yes**, describe the new output and/or changes to the existing output:</br>
- [x] Will this PR result in changes to existing METplus Use Cases? **[No]**</br>
If **yes**, create a new **Update Truth** [METplus issue](https://github.com/dtcenter/METplus/issues/new/choose) to describe them.
- [x] Do these changes introduce new SonarQube findings? **[No]**</br>
If **yes**, please describe:
- [ ] Please complete this pull request review by **[6/27/2024]**.</br>
## Pull Request Checklist ##
See the [METplus Workflow](https://metplus.readthedocs.io/en/latest/Contributors_Guide/github_workflow.html) for details.
- [x] Review the source issue metadata (required labels, projects, and milestone).
- [x] Complete the PR definition above.
- [x] Ensure the PR title matches the feature or bugfix branch name.
- [x] Define the PR metadata, as permissions allow.
Select: **Reviewer(s)** and **Development** issue
Select: **Milestone** as the version that will include these changes
Select: **Coordinated METplus-X.Y Support** project for bugfix releases or **MET-X.Y.Z Development** project for official releases
- [x] After submitting the PR, select the :gear: icon in the **Development** section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
- [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
- [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No] If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
grid_stat:
export MET_SEEPS_GRID_CLIMO_NAME="/d1/personal/hsoh/data/PPT24_seepsweights_grid.nc" export SEEPS_GRID_CLIMO_NAME="" /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/bin/grid_stat \ /d1/projects/MET/MET_test_data/unit_test/model_data/seeps/gpm_2021120100_2021120200_trmmgrid.nc \ /d1/projects/MET/MET_test_data/unit_test/model_data/seeps/prods_op_gl-mn_2021120100_f024_A24_trmmgrid.nc \ /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/internal/test_unit/config/GridStatConfig_SEEPS \ -outdir /d1/personal/hsoh/MET/test_output/feature_2601_seeps_climo_config/grid_stat -v 7 >& log_grid_stat2.log grep "SeepsClimoBase::get_climo_filename" log_grid_stat2.log DEBUG 7: SeepsClimoBase::get_climo_filename() -> SEEPS climo name="/d1/personal/hsoh/data/PPT24_seepsweights_grid.nc"
export SEEPS_GRID_CLIMO_NAME='/d1/projects/MET/MET_test_data/unit_test/climatology_data/seeps/PPT24_seepsweights_grid.nc' /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/bin/grid_stat \ /d1/projects/MET/MET_test_data/unit_test/model_data/seeps/gpm_2021120100_2021120200_trmmgrid.nc \ /d1/projects/MET/MET_test_data/unit_test/model_data/seeps/prods_op_gl-mn_2021120100_f024_A24_trmmgrid.nc \ /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/internal/test_unit/config/GridStatConfig_SEEPS \ -outdir /d1/personal/hsoh/MET/test_output/feature_2601_seeps_climo_config/grid_stat -v 7 >& log_grid_stat3.log grep "SeepsClimoBase::get_climo_filename" log_grid_stat3.log DEBUG 7: SeepsClimoBase::get_climo_filename() -> SEEPS climo name="/d1/personal/hsoh/data/PPT24_seepsweights_grid.nc"
export BEG_DS='-1800' export END_DS='1800' export FCST_FIELD_LEVEL='(,)' export FCST_FIELD_NAME='APCP_24' export OBS_DICT='{ field = [ { name = "TP24"; level = "L0"; is_precipitation = TRUE; } ]; }' export OUTPUT_PREFIX='NCMET_NAM_NDAS_SEEPS' export SEEPS_P1_THRESH='ge0.1&&le0.85' mv /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/share/met/climo/seeps/PPT24_seepsweights.nc \ /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/share/met/climo/seeps/PPT24_seepsweights.nc.deleted export SEEPS_POINT_CLIMO_NAME='/d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/share/met/climo/seeps/PPT24_seepsweights.nc.deleted'
/d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/bin/point_stat \ /d1/projects/MET/MET_test_data/unit_test/model_data/met_nc/nam/nam_2012040900_F036_APCP24.nc \ /d1/personal/hsoh/MET/test_output/feature_2601_seeps_climo_config/pb2nc/ndas.20120410.t12z.prepbufr.tm00.nc \ /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/internal/test_unit/config/PointStatConfig_SEEPS \ -outdir /d1/personal/hsoh/MET/test_output/feature_2601_seeps_climo_config/point_stat -v 7 >& log_point_stat.log grep -a "get_climo_filename" log_point_stat.log DEBUG 7: SeepsClimoBase::get_climo_filename() -> SEEPS climo name="/d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/share/met/climo/seeps/PPT24_seepsweights.nc.deleted"
mv /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/share/met/climo/seeps/PPT24_seepsweights.nc.deleted \ /d1/personal/hsoh/git/features/feature_2601_seeps_climo_config/MET/share/met/climo/seeps/PPT24_seepsweights.nc