dtcenter / MET

Model Evaluation Tools
https://dtcenter.org/community-code/model-evaluation-tools-met
Apache License 2.0
79 stars 24 forks source link

Confirm that the METplus differences logic handles MTD output file #977

Open dwfncar opened 6 years ago

dwfncar commented 6 years ago

Describe the Task

The testing infrastructure for MET does not do a good job checking for differences in MTD output files. It first calls diff, and if there are no differences, everything is fine. If there are differences, you see this type of error:

COMPARING mtd/mtd_BASIC_20100517_010000V_2d.txt
file1: test_output_rev5319/mtd/mtd_BASIC_20100517_010000V_2d.txt
file2: test_output_rev5351/mtd/mtd_BASIC_20100517_010000V_2d.txt
cat: /d3/projects/MET/MET_regression/NB20180319/test_rev5351/hdr/met_NA.hdr: No such file or directory
Error in strsplit(strHdr, " ") : non-character argument

In addition: There were 50 or more warnings (use warnings() to see the first 50)

ERROR: compareStat() failed

This task is to update the testing infrastructure to handle the MTD output.

Time Estimate

Estimate the amount of work required here. Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

Labels

Projects and Milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

JohnHalleyGotway commented 2 weeks ago

Note that #2718 switches from internal MET differencing logic to using METplus instead. Confirm that differencing of MTD outputs are well-supported there.