[x] Describe testing already performed for these changes:
on host 'seneca', use the following environment to replicate the environment that produces the PerformanceWarning (pandas 2.0.3):
cd $METdataio/METreformat
python write_stat_ascii.py point_stat.yaml
verify that there is no PerformanceWarning to stdout
verify that the output is identical to the output generated from the previous version, which generated the PerformanceWarning.
[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
[x] Describe testing already performed for these changes: on host 'seneca', use the following environment to replicate the environment that produces the PerformanceWarning (pandas 2.0.3):
conda activate /d1/personal/mwin/miniconda3/envs/rrfs_metplotpy_env
clone the bugfix_219_performance_warning branch:
git clone https://github.com/dtcenter/METdataio/
git checkout bugfix_219_performance_warning
set the PYTHONPATH:
setenv PYTHONPATH $METDATAIO:$METDATAIO/METdbLoad:$METDATAIO/METdbLoad/ush:$METDATAIO/METreformat
or
export PYTHONPATH=$METDATAIO:$METDATAIO/METdbLoad:$METDATAIO/METdbLoad/ush:$METDATAIO/METreformat
Where $METDATAIO is path-to/METdataio
modified the $METDATAIO/METreformat/point_stat.yaml file:
Run the command:
original output: warning_point_stat_reformatted.txt
new output without XML spec file: no_xml_no_warn_point_stat_reformatted.txt e and no more warning:
diff of two files yields no differences.
Will Mayfield also tested on 'hera' and no longer observes the PerformanceWarning
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
perform the same steps on 'seneca', use the same conda env (permissions granted):
clone the bugfix_219_performance_warning branch:
git clone https://github.com/dtcenter/METdataio/
git checkout bugfix_219_performance_warning
set the PYTHONPATH:
setenv PYTHONPATH $METDATAIO:$METDATAIO/METdbLoad:$METDATAIO/METdbLoad/ush:$METDATAIO/METreformat
or
export PYTHONPATH=$METDATAIO:$METDATAIO/METdbLoad:$METDATAIO/METdbLoad/ush:$METDATAIO/METreformat
Where $METDATAIO is path-to/METdataio
Modify the point_stat.yaml file:
for the input_data_dir setting, continue using the data in /d1/personal/mwin/RRFS_performancewarning/from_Will/metplotpy/stage_point_stat_output
permissions allowed for all to access
Run the command:
cd $METdataio/METreformat
python write_stat_ascii.py point_stat.yaml
verify that there is no PerformanceWarning to stdout
verify that the output you generated is identical to:
no_xml_no_warn_point_stat_reformatted.txt
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
[x] Do these changes include sufficient testing updates? [NA, using same tests]
[x] Will this PR result in changes to the test suite? [ No] If yes, describe the new output and/or changes to the existing output:
[x] Please complete this pull request review by for Beta1 Release.
Pull Request Checklist
See the METplus Workflow for details.