[x] Describe testing already performed for these changes:
working with METdataio feature_282_enhance_schema branch
loaded the mv_mysql.sql schema into a test database on 'mohawk' (mv_load_test)
loaded updated ECNT data
ran tests in METdbLoad/sql/tests/update_schema_6.0_beta4 to verify that the database was created, the ECNT, VCNT, VL1L2, and VAL1L2 tables were created with the expected new columns.
Verified that only one row of result was returned for specific values of ign_conv_oerr and ign_corr_oerr in the line_data_ecnt table
data used is available in the METdataio/METdbLoad/tests/update_schema_6.0_beta4/Data
(only the ECNT tarball was loaded into the database)
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
in your own environment, verify that the new schema with updated data works.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ] added content to the Contributor's Guide
[x] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
[x] Please complete this pull request review by [Fill in date].
[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
[x] Describe testing already performed for these changes:
working with METdataio feature_282_enhance_schema branch
loaded the mv_mysql.sql schema into a test database on 'mohawk' (mv_load_test)
loaded updated ECNT data
ran tests in METdbLoad/sql/tests/update_schema_6.0_beta4 to verify that the database was created, the ECNT, VCNT, VL1L2, and VAL1L2 tables were created with the expected new columns.
Verified that only one row of result was returned for specific values of ign_conv_oerr and ign_corr_oerr in the line_data_ecnt table
data used is available in the METdataio/METdbLoad/tests/update_schema_6.0_beta4/Data (only the ECNT tarball was loaded into the database)
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
in your own environment, verify that the new schema with updated data works.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ] added content to the Contributor's Guide
[x] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Do these changes introduce new SonarQube findings? [No] If yes, please describe:
[x] Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.