Feature update modulefiles

[jprestop]

Pull Request Testing

• [x] Describe testing already performed for these changes:
  I tested loading these new modulefiles on the various machines.

• [x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  Please review the files for any obvious mistakes.

• [x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• [x] Do these changes include sufficient testing updates? [N/A]

• [x] Will this PR result in changes to the test suite? [No]
  If yes, describe the new output and/or changes to the existing output:
  

• [x] Do these changes introduce new SonarQube findings? [No]
  If yes, please describe:

• [x] Please complete this pull request review by [20240503].
  

Pull Request Checklist

See the METplus Workflow for details.

• [x] Add any new Python packages to the METplus Components Python Requirements table.
• [No issue] Review the source issue metadata (required labels, projects, and milestone).
• [x] Complete the PR definition above.
• [x] Ensure the PR title matches the feature or bugfix branch name.
• [x] Define the PR metadata, as permissions allow. Select: Reviewer(s) Select: Organization level software support Project or Repository level development cycle Project Select: Milestone as the version that will include these changes
• [No issue] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

Thank you, @bikegeek. Is METdbLoad only for database functionality? If so, I think it is true that METdbLoad would not be used on WCOSS2, in which case, I will add prepend-path for PATH and PYTHONPATH for all but the 3.0.0_acorn file (the WCOSS2 test machine). If not, I will add it to all. I will likely not get back to this until next week, but I will follow up and request a re-review then.

[bikegeek]

The METdbLoad has some functionality used by the METreformat code to read in MET .stat and .tcst files.

On Thu, Apr 25, 2024 at 10:43 AM Julie Prestopnik @.***> wrote:

Thank you, @bikegeek https://github.com/bikegeek. Is METdbLoad only for database functionality? If so, I think it is true that METdbLoad would not be used on WCOSS2, in which case, I will add prepend-path for PATH and PYTHONPATH for all but the 3.0.0_acorn file (the WCOSS2 test machine). If not, I will add it to all. I will likely not get back to this until next week, but I will follow up and request a re-review then.

— Reply to this email directly, view it on GitHub https://github.com/dtcenter/METdataio/pull/302#issuecomment-2077724255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4UJHVT3TPW76A67TJTAXDY7EXB5AVCNFSM6AAAAABGZELINSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXG4ZDIMRVGU . You are receiving this because you were mentioned.Message ID: @.***>

[jprestop]

@bikegeek I have added entries to the prepend-path for PATH and PYTHONPATH to all of the files. I have a requested a re-review. There is no rush. Thank you for your attention to detail with these modulefiles.