[x] Describe testing already performed for these changes:
ran pytest tests in METdataio/METreformat/test
generated MPR reformatting for scatter plot (maintains all MPR columns as generated by MET point_stat with all columns labelled) and generated scatter plot
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
set up the config file by going to section 7.2 Required Components and fill in the settings for the Definition of Mandatory Config Settings (expandable link) in the reformat_stat.yaml config file
on 'seneca', use the /d1/personal/mwin/miniconda3/envs/mp_analysis_env
clone the METdataio feature255_reformat_mpr branch
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x ] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
[x] Describe testing already performed for these changes:
ran pytest tests in METdataio/METreformat/test
generated MPR reformatting for scatter plot (maintains all MPR columns as generated by MET point_stat with all columns labelled) and generated scatter plot
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
on 'seneca', use the /d1/personal/mwin/miniconda3/envs/mp_analysis_env
clone the METdataio feature255_reformat_mpr branch
set up the PYTHONPATH:
use this data to reformat (remove the .txt extension):
point_stat_LAND_TOPO_MASK_120000L_20120409_120000V_mpr.stat.txt
You should get this file: reformatted_usecase_data_for_scatter.txt
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[x] Do these changes include sufficient testing updates? [Yes ]
[x] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Do these changes introduce new SonarQube findings? [Yes] If yes, please describe: Quality Gate fails
[x] Please complete this pull request review by [before beta5 release].
Pull Request Checklist
See the METplus Workflow for details.