[x] Describe testing already performed for these changes:
loaded schema onto 'mohawk' database
ran tests to check for the total_dir columns in the vl1l2, val1l2, and vcnt tables
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
verify the correctness of the mv_mysql.sql file (METdbLoad/sql)
verify the correctness of the update_for_6_0_beta5.sql file (METdbLoad/sql/updates)
any other tests if they affect METexpress
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
[x] Do these changes include sufficient testing updates? [Yes]
[x] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Do these changes introduce new SonarQube findings? [Yes]
If yes, please describe: Quality gate fails because of "duplicate" code in the tests.
[x] Please complete this pull request review by [as soon as possible for beta5 release for Friday June 29 (latest)].
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
[x] Describe testing already performed for these changes: loaded schema onto 'mohawk' database ran tests to check for the total_dir columns in the vl1l2, val1l2, and vcnt tables
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
verify the correctness of the mv_mysql.sql file (METdbLoad/sql)
verify the correctness of the update_for_6_0_beta5.sql file (METdbLoad/sql/updates)
any other tests if they affect METexpress
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
[x] Do these changes include sufficient testing updates? [Yes]
[x] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Do these changes introduce new SonarQube findings? [Yes] If yes, please describe: Quality gate fails because of "duplicate" code in the tests.
[x] Please complete this pull request review by [as soon as possible for beta5 release for Friday June 29 (latest)].
Pull Request Checklist
See the METplus Workflow for details.