[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
[x] Describe testing already performed for these changes:
ran the test test_reformatting.py in the METdataio/METreformat/test directory
on seneca:
using this conda environment: /d1/personal/mwin/miniconda3/envs/mp_analysis_env
/d1/personal/mwin/feature_255_reformat_mpr
set the PYTHONPATH:
/d1/personal/mwin/feature_255_reformat_mpr/METdataio:/d1/personal/mwin/feature_255_reformat_mpr/METdataio/METdbLoad:/d1/personal/mwin/feature_255_reformat_mpr/METdataio/METdbLoad/ush:/d1/personal/mwin/feature_255_reformat_mpr/METdataio/METreformat
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
run tests as above
verify that the documentation contains sufficient information: https://metdataio.readthedocs.io/en/feature_255_reformat_mpr/Users_Guide/reformat_stat_data.html
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
[x] Do these changes include sufficient testing updates? [Yes ]
[x] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Do these changes introduce new SonarQube findings? [Probably] If yes, please describe: Quality gate will probably flag repeated code in the tests
[x] Please complete this pull request review by [Earliest convenience for beta5 release].
Pull Request Checklist
See the METplus Workflow for details.