318: Get existing tests working

[John-Sharples]

In this PR:

• Added functionality to conftest.py to write some test files to a temp directory
• Use temp files to run tests in test/
• Tests can now be run with pytest test/
• METdbLoad/test/test_tables.py wrapped in a function and marked to skip.

Not in the PR

• An assessment of whether the current tests do anything useful
• The tests in tests/ (plural) still error during setup

Pull Request Testing

• [x] Describe testing already performed for these changes:
  Run locally

• [x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  Please check these changes run wherever we expect this code to work

• [x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] Extensive comments in code.

• [x] Do these changes include sufficient testing updates? [Yes]

• [x] Will this PR result in changes to the test suite? [Yes]
  If yes, describe the new output and/or changes to the existing output:
  tests now use temp files and can be run anywhere.

• [x] Do these changes introduce new SonarQube findings? [Yes or No]
  If yes, please describe: Not sure.

• [x] Please complete this pull request review by [Fill in date].
  No rush.

Pull Request Checklist

See the METplus Workflow for details.

• [x] Add any new Python packages to the METplus Components Python Requirements table.
• [x] Review the source issue metadata (required labels, projects, and milestone).
• [x] Complete the PR definition above.
• [x] Ensure the PR title matches the feature or bugfix branch name.
• [x] Define the PR metadata, as permissions allow. Select: Reviewer(s) and Development issue Select: Milestone as the version that will include these changes Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
• [ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

[bikegeek]

I will let you do the Squash and merge, and delete the branch.

[John-Sharples]

@bikegeek It appears I'm not authorised to merge this PR

[bikegeek]

You have 'write' privileges to this repository, I'll see what other things need to be set for you to perform merges. In the meantime, I've performed the squash and merge.

Regards, Minna

On Sun, Jul 28, 2024 at 4:22 PM John Sharples @.***> wrote:

@bikegeek https://github.com/bikegeek It appears I'm not authorised to merge this PR

— Reply to this email directly, view it on GitHub https://github.com/dtcenter/METdataio/pull/319#issuecomment-2254669005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4UJHXQJGYEKVWGKOUKJYTZOVVIZAVCNFSM6AAAAABLPT7VPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGY3DSMBQGU . You are receiving this because you were mentioned.Message ID: @.***>