dtcenter / METdataio

https://metdataio.readthedocs.io/en/latest/index.html
Apache License 2.0
5 stars 3 forks source link

Handle variable length lines with more than 125 columns after the header, especially for HiRA #78

Closed venitahagerty closed 2 years ago

venitahagerty commented 2 years ago

Describe the Problem

*With the new ability to apply the HiRA method to ensembles, some variable length lines can get much longer - theoretically to at least 2000 columns. If all input lines are treated as having the ability to have up to 2000 columns, more memory will be needed, and the program will be slower.

For now, the fix is to identify lines that will be too long, skip them, and give an error message.

Long term, it might be better to either increase the column limit or process long lines separately. Increasing the limit will require changes to the VSDB code.*

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment: 1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop) 2. OS: (e.g. RedHat Linux, MacOS) 3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error Post relevant sample data following these instructions: https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

Needed for release.

Funding Source

NONE

Define the Metadata

Assignee

Labels

Projects and Milestone

Define Related Issue(s)

Related to MET issue [https://github.com/dtcenter/MET/issues/1583]

Bugfix Checklist

See the METplus Workflow for details.

venitahagerty commented 2 years ago

Finished adding fix for lines too long.