Inconsistency between plots generated in METviewer via R vs Python for MODE

bikegeek commented 4 months ago

Replace italics below with details for this issue.

Describe the Problem

Discovered by Michelle while generating MODE plots in METviewer, and verified by John HG see details below.

Michelle (and METplus-Analysis team),

I'm confident that you've found a bug somewhere in the METplus Analysis suite.

It can be demonstrated on this instance of METviewer: http://dtcenter.ucar.edu/met/metviewer/servlet

The attached files show running the exact same XML configuration, one using the Python logic and the other using R. They both produce essentially the same "R data" file. Although for some reason the "fcst_valid" column contains the current timestamp when the plot was run... and since the plots were generated at different times, those values don't match.

However there's a huge difference in the resulting png plots. The R version sums the data up across multiple initialization timestamps while the Python version plots only one of the values.

For example, for the red line "nostoch - fcst" at the 36 hour lead time, I see 12 lines of data (see below).

The R plot appears to plot their sum of 161 while the Python plot appears to plot a value of 14, which happens to be the 2nd to last value in the list below.

So there appears to be a big discrepancy in the legacy R plotting logic and the new Python plotting logic for counts of MODE objects. There's also a question as to why the current timestamp is written to the fcst_valid column... that's not necessarily wrong... just want to double-check that it's the expected behavior.

grep nostoch plot_icperts_mode_apcp_obj_test-fixed-init-Python.data | grep "360000" | grep FSA

nostoch 2022-04-30 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 15

nostoch 2022-05-02 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 16

nostoch 2022-05-03 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 16

nostoch 2022-05-04 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 9

nostoch 2022-05-05 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 14

nostoch 2022-05-06 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 15

nostoch 2022-05-07 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 15

nostoch 2022-05-08 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 13

nostoch 2022-05-09 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 6

nostoch 2022-05-10 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 7

nostoch 2022-05-11 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 14

nostoch 2022-05-12 00:00:00 2024-01-24 17:16:43 360000 APCP_01_ENS_NEP_ge2.54_NBRHD729 CNTSUM_FSA 21

plot_icperts_mode_apcp_obj_test-fixed-init-Python

plot_icperts_mode_apcp_obj_test-fixed-init-R.data.txt

plot_icperts_mode_apcp_obj_test-fixed-init-Python.data.txt

plot_icperts_mode_apcp_obj_test-fixed-init-Python.xml.txt

plot_icperts_mode_apcp_obj_test-fixed-init-R.xml.txt

Expected Behavior

MODE Plots generated in METviewer using BOTH legacy R script and Python should have identical results (consistent times plotted, etc.)

Environment

Describe your runtime environment: 1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop) 2. OS: (e.g. RedHat Linux, MacOS) 3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error Post relevant sample data following these instructions: https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Select Organization level Project for support of the current coordinated release
[ ] Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
[ ] Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

[ ] METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of main_\. Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
[ ] Fix the bug and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Add any new Python packages to the METplus Components Python Requirements table.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into main_\. Pull request: bugfix <Issue Number> main_<Version> <Description>
[ ] Define the pull request metadata, as permissions allow. Select: Reviewer(s) and Development issues Select: Organization level software support Project for the current coordinated release Select: Milestone as the next bugfix version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Complete the steps above to fix the bug on the develop branch. Branch name: bugfix_<Issue Number>_develop_<Description> Pull request: bugfix <Issue Number> develop <Description> Select: Reviewer(s) and Development issues Select: Repository level development cycle Project for the next official release Select: Milestone as the next official version
[ ] Close this issue.

bikegeek commented 4 months ago

While investigating this issue, determine if this is observed with other linetypes. Include other linetypes besides MODE when testing.

TatianaBurek commented 4 months ago

When is this needed? Tatiana is probably not going to get around to implementing the METcalcpy portion and I'm unavailable for a couple of weeks.

Minna Win Pronouns: she/her NSF NCAR DTC & Research Applications Lab Phone: 303-497-8423

My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.

On Tue, Feb 27, 2024 at 11:17 AM Christina Kalb @.***> wrote:

Is there a time frame for when this issue may be fixed?

— Reply to this email directly, view it on GitHub https://github.com/dtcenter/METplotpy/issues/413#issuecomment-1967334483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4UJHSBJKHFPYBGPKHDB43YVYPM5AVCNFSM6AAAAABCJFUKPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXGMZTINBYGM . You are receiving this because you authored the thread.Message ID: @.***>

CPKalb commented 3 months ago

I am not certain. Let me check and I'll get back to you.

bikegeek commented 3 months ago

Ok, let me know and I'll see if I can squeeze something in if this is urgent.

Minna Win Pronouns: she/her NSF NCAR DTC & Research Applications Lab Phone: 303-497-8423

My work hours may not be your work hours. Please do not feel obliged to reply to this email outside of your normal working hours.

On Tue, Feb 27, 2024 at 1:32 PM Christina Kalb @.***> wrote:

I am not certain. Let me check and I'll get back to you.

— Reply to this email directly, view it on GitHub https://github.com/dtcenter/METplotpy/issues/413#issuecomment-1967542666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4UJHVP4ROKYRC5NTU4ONDYVY7HNAVCNFSM6AAAAABCJFUKPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXGU2DENRWGY . You are receiving this because you authored the thread.Message ID: @.***>

CPKalb commented 2 months ago

This is intermediate in urgency so I don't think you need to squeeze something in. We have ways to get around it for now.

dtcenter / METplotpy