[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
generate a ROC diagram using the same data
Instructions:
if running on 'seneca', use this CONDA environment: _/d1/personal/mwin/miniconda3/envs/mp_analysisenv
clone the following code:
set up the PYTHONPATH:
use this data(remove .txt extension): This has been reformatted by the METdataio reformatter wind_only.data.txt
use this custom configuration file (remove .txt extension): ctc_from_dataio_ROC.yaml.txt
generate the plot:
_python $PLOTPY/metplotpy/plots/roc_diagram/roc_diagram.py /path/to/ctc_from_dataioROC.yaml
should generate this plot:
NOTE: This is also set up on 'seneca' under: /d1/personal/mwin/feature_424_ROC_CTC/
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[x] Do these changes include sufficient testing updates? [Yes ]
[x] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Please complete this pull request review by anytime before the beta5 release.
Pull Request Checklist
See the METplus Workflow for details.