dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
98 stars 37 forks source link

pcp_combine wrapper refactor #177

Open georgemccabe opened 5 years ago

georgemccabe commented 5 years ago

The code in pcp_combine_wrapper.py is very messy. It could be cleaned up to be more readable. This could also lead to simplifying some of the complex logic. I am creating this ticket so I have an issue number to associate with a feature branch for this work.

georgemccabe commented 5 years ago

This wrapper has been greatly improved to help implement sub-hourly input support and bucket interval resets, but it could always be improved more. The get_accumulation function could still be refactored more to contain many small components so it can be tested.