Feature #2299 / #2310 Remove deprecated MET config env vars and TCMPRPlotter

georgemccabe commented 1 year ago

Change Summary

2310 and related use cases
2299
- Remove calls to set env vars that are deprecated (e.g. don't start with METPLUS_)
- Change logic to validate MET config files to use list of deprecated env vars specific to each wrapper
- Instruct users that have deprecated env vars in their MET config to use provided version of wrapped MET config and set values in METplus config instead.

Other Changes

Fix bug in diff util that incorrectly reports the wrong column name when diffs are found in a stat file
Changed use case to set MODEL and OBTYPE because default values are no longer used (to prevent diffs in test output)

Pull Request Testing

[X] Describe testing already performed for these changes:

Ensured all tests pass

[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes
Verify all tests pass (no diffs)
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

I think so

[X] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [No]
[X] Please complete this pull request review by 9/15/2023.

Pull Request Checklist

See the METplus Workflow for details.

[X] Add any new Python packages to the METplus Components Python Requirements table.
[X] Review the source issue metadata (required labels, projects, and milestone).
[X] Complete the PR definition above.
[X] Ensure the PR title matches the feature or bugfix branch name.
[X] Define the PR metadata, as permissions allow. Select: Reviewer(s) Select: Organization level software support Project or Repository level development cycle Project Select: Milestone as the version that will include these changes
[X] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

jprestop commented 1 year ago

HI @georgemccabe. It sounds like you expected no differences, but the short_range:2-6 tests failed due to the following differences. Are they acceptable differences?

**************************************************
Summary:

ERROR: Some differences were found
Text diff
A:/data/truth/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V_dmap.txt
B:/data/output/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V_dmap.txt

Text diff
A:/data/truth/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_010000L_20190521_010000V_dmap.txt
B:/data/output/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_010000L_20190521_010000V_dmap.txt

Text diff
A:/data/truth/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_010000L_20190521_010000V.stat
B:/data/output/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_010000L_20190521_010000V.stat

Text diff
A:/data/truth/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V.stat
B:/data/output/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V.stat

Finished comparing directories
**************************************************

georgemccabe commented 1 year ago

@jprestop, thanks for pointing that out. That is weird, because the diff results were different when I tested before the PR so I changed the use case to produce the results that are showing diffs now. FYI, there is an expandable tab above the diff summary that you can click to see the full diff results or you can just search for ERROR in the log file (search bar is above the log window, don't use the browser search). Below is one of the diffs. I'll push a change to the use case conf to prevent this diff.

COMPARING short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V_dmap.txt file_A: /data/truth/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V_dmap.txt file_B: /data/output/short_range/GridStat_fcstFV3_obsGOES_BrightnessTempDmap/short_range/brightness_temperature/grid_stat/grid_stat_FV3_core_lsm1_020000L_20190521_020000V_dmap.txt

Using default rounding precision 6 Comparing text files Comparing stat files ERROR: Stat line differs A: V12.0.0 WRF NA 020000 20190521_020000 20190521_020000 000000 20190521_020000 20190521_020000 SBTA1613_topofatmosphere K top_of_atmosphere channel_13_brightness_temperature NA , ANALYS FULL NEAREST 1 <=235 <=235 NA NA DMAP 1701276 149369 151257 0.98752 60.47303 251.28669 8.00318 4.40839 4.40839 8.00318 6.20578 0.70706 0.7464 0.70706 0.7464 0.72673 4.12716 2.32976 2.32976 4.12716 3.22846 5853.38045 0.86142 1447170014088 B: V12.0.0 FCST NA 020000 20190521_020000 20190521_020000 000000 20190521_020000 20190521_020000 SBTA1613_topofatmosphere K top_of_atmosphere channel_13_brightness_temperature NA , OBS FULL NEAREST 1 <=235 <=235 NA NA DMAP 1701276 149369 151257 0.98752 60.47303 251.28669 8.00318 4.40839 4.40839 8.00318 6.20578 0.70706 0.7464 0.70706 0.7464 0.72673 4.12716 2.32976 2.32976 4.12716 3.22846 5853.38045 0.86142 1447170014088

Diff in MODEL: A: WRF B: FCST Diff in OBTYPE: A: ANALYS B: OBS

georgemccabe commented 1 year ago

@jprestop, on second though, WRF is not a good value to have here because the forecast data is not WRF. I think we can accept these diffs and update the truth data instead. What do you think?

dtcenter / METplus