Feature 2253 tc csv writer

John-Sharples commented 1 year ago

This PR is now ready for review.

Two changes:

Pull Request Testing

[x] Describe testing already performed for these changes:
Test run locally
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review changes to source code
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? Yes
[x] Do these changes include sufficient testing updates? Yes
[x] Will this PR result in changes to the test suite? [es
If yes, describe the new output and/or changes to the existing output:
More tests will run for tc_pairs_wrapper
[x] Please complete this pull request review by [Fill in date].

See the METplus Workflow for details.

[x] Add any new Python packages to the METplus Components Python Requirements table.
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow. Select: @georgemccabe Select: METplus-Wrappers-6.0.0 Development Select: METplus-6.0.0
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

John-Sharples commented 1 year ago

Thanks for the feedback, @georgemccabe. I'll make your suggested changes and resubmit the tests.

John-Sharples commented 1 year ago

Updated as per discussion. Also added a new test to cover error message in _get_basin_cyclone_from_bdeck