dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
98 stars 37 forks source link

Feature #2340 TCDiag one_time_per_file_flag #2374

Closed georgemccabe closed 1 year ago

georgemccabe commented 1 year ago

Added support for setting one_time_per_file_flag. No changes were needed for the change to lead as it was already configurable via METplus config variable LEAD_SEQ.

Pull Request Testing

Added unit test for setting new MET config variable

Review changes

A new unit test was added but it should still pass

Pull Request Checklist

See the METplus Workflow for details.

jvigh commented 1 year ago

From @georgemccabe: Jonathan, I created a PR with changes to the TCDiag wrapper that match the latest changes to the MET tool. https://github.com/dtcenter/METplus/pull/2374John, this completes the work that was listed in METplus issue #2340. In the issue you say: This issue is enhance that wrapper as needed, and described below. Rather than creating separate issues for each change, I'm bundling them together into this single issue and assigning it to the beta3 development cycle. If it is more convenient to actually make the changes as we go, please feel free to close this issue, and I'll create a new one for additional changes. I reassigned the issue to beta2 (current cycle). I suggest we close this issue after this PR is merged, then you can reopen it and add a comment for new enhancements as needed. What do you think?

The pull requests for each enhancement will still be tied to the appropriate beta, so the timeline of the changes will be preserved even if the issue is moved from cycle to cycle.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6385352205


Totals Coverage Status
Change from base Build 6341220440: 0.002%
Covered Lines: 8113
Relevant Lines: 9560

💛 - Coveralls
georgemccabe commented 1 year ago

@jvigh, these changes include additions to the Glossary and Python Wrappers chapters of the METplus User's Guide to describe the new variable. The details of this setting belong in the MET User's Guide, where it should already be thoroughly documented.