Closed lisagoodrich closed 10 months ago
I only reviewed the User's Guide content to make sure there are no conflicts with my changes since I am working on those files. I don't see anything of concern, but I did find a minor typo (see suggested change).
Pull Request Testing
The only area where I didn't check the headers was here: https://metplus.readthedocs.io/en/feature_898_headers/generated/met_tool_wrapper/index.html and here: https://metplus.readthedocs.io/en/feature_898_headers/generated/model_applications/index.html I do not know where these files are being generated.
REMINDER: Please keep the issue open. The MET headers need to be finished before this issue can close.
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: I feel very confident that these headers are correct. However, this was a tedious and complex process. I really struggled on the Release Guide. There are over 100 files that link to many different directories. This formatting also assumes the file sections will be at the SAME level across different tools. So far, this is the case. Please do a spot check of the headers as you see fit. George asked to be included on this pull request. Since is working in METplus.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes, there are no errors.]
[x] Do these changes include sufficient testing updates? [Yes]
[x] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Please complete this pull request review by 11/3/23.
Pull Request Checklist
See the METplus Workflow for details.