Testing - changed pb2nc and command_builder tests to use %H instead of %2H because %2H passed to strftime behaves differently between Mac and Linux
Removed CommandRunner class and moved command running logic to metplus/util/run_util
Added unit tests for logging and command running
Pull Request Testing
[X] Describe testing already performed for these changes:
Added new unit tests
Ran met_tool_wrapper/GridStat/GridStat.conf use case playing with different options and confirmed expected behavior occurs regards to logging
config.LOG_TO_TERMINAL_ONLY=True to force logging to screen only
config.GRID_STAT_OUTPUT_FLAG_CTC=CHICKEN to force error in GridStat
config.LOG_LINE_FORMAT="%(levelname)s: %(message)s" to change formatting of log lines to exclude timestamp, line numbers, etc. -- In previous versions of METplus this formatting was not applied when logging only to terminal, e.g. LOG_METPLUS = empty string
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Run METplus use case (e.g. met_tool_wrapper/GridStat/GridStat.conf) multiple times with different config overrides (examples listed above) and confirm that correct behavior occurs with regards to logging
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
Code coverage increased from 90% to 91%
[X] Will this PR result in changes to the test suite? [No]
New tests were added but they should all pass
[X] Please complete this pull request review by 11/3/2023.
[X] Review the source issue metadata (required labels, projects, and milestone).
[X] Complete the PR definition above.
[X] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Change Summary
Pull Request Testing
[X] Describe testing already performed for these changes:
Added new unit tests
Ran met_tool_wrapper/GridStat/GridStat.conf use case playing with different options and confirmed expected behavior occurs regards to logging
config.LOG_TO_TERMINAL_ONLY=Trueto force logging to screen onlyconfig.GRID_STAT_OUTPUT_FLAG_CTC=CHICKENto force error in GridStatconfig.LOG_LINE_FORMAT="%(levelname)s: %(message)s"to change formatting of log lines to exclude timestamp, line numbers, etc. -- In previous versions of METplus this formatting was not applied when logging only to terminal, e.g. LOG_METPLUS = empty string[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Run METplus use case (e.g. met_tool_wrapper/GridStat/GridStat.conf) multiple times with different config overrides (examples listed above) and confirm that correct behavior occurs with regards to logging
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
Code coverage increased from 90% to 91%
[X] Will this PR result in changes to the test suite? [No] New tests were added but they should all pass
[X] Please complete this pull request review by 11/3/2023.
Pull Request Checklist
See the METplus Workflow for details.