[x] Describe testing already performed for these changes:.
This was a tedious task. I ended up creating a spreadsheet, METplus wrappers and tables comparison to compare the Python wrappers file/list to the the tables. If it was complex with a lot of changes, I created a separate tab for that section. There is a main tab, "overview" where I could track my work. The tabs were useful to compare the Python wrappers list to the tables (listed below on the web) for a one to one comparison.
Double check that the tables are correct for Section 6.33.3 TCStatConfig_wrapped, for ${METPLUS_VALID_INC} and ${METPLUS_VALID_EXC} web
There were a lot of changes but I feel confident about the ordering.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes there are no errors]
[x] Do these changes include sufficient testing updates? [Yes]
[x] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Please complete this pull request review by 11/13/23.
[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
I saved my work by section. Then I would view the results on the feature_2405_match_tables2wrapper web page, and compare the tables to the specific Python wrapper list.
Double check that the tables are correct for Section 6.33.3 TCStatConfig_wrapped, for ${METPLUS_VALID_INC} and ${METPLUS_VALID_EXC} web
There were a lot of changes but I feel confident about the ordering.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes there are no errors]
[x] Do these changes include sufficient testing updates? [Yes]
[x] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Please complete this pull request review by 11/13/23.
Pull Request Checklist
See the METplus Workflow for details.