Closed georgemccabe closed 9 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
metplus/util/met_config.py | 44 | 48 | 91.67% | ||
<!-- | Total: | 106 | 110 | 96.36% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
metplus/util/met_config.py | 1 | 94.63% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 6869072930: | 0.09% |
Covered Lines: | 8506 |
Relevant Lines: | 9372 |
Change Summary
GEN_ENS_PROD_NMEP_SMOOTH_TYPE_METHOD
andGEN_ENS_PROD_NMEP_SMOOTH_TYPE_WIDTH
. These variables are still supported but users can supply additional values withGEN_ENS_PROD_NMEP_SMOOTH_TYPE1_METHOD
andGEN_ENS_PROD_NMEP_SMOOTH_TYPE2_WIDTH
, etc. This was done to support WaveletStat multiple values fortitle.location.x_ll
andtitle.location.y_ll
.Pull Request Testing
[X] Describe testing already performed for these changes:
Ran use case and confirmed it ran successfully
Ran use case with all optional configs that set MET variables and confirmed the set the environment variable values correctly
Added unit tests for new wrapper
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review changes for any typos
Review use case documentation and new Python Wrappers sections
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [Yes]
After this PR is merged, new use case should be moved to another met_tool_wrapper group and truth data should be updated
Pull Request Checklist
See the METplus Workflow for details.