These are changes to match the changes to the MET tool. See issue #2432 for details.
Pull Request Testing
[X] Describe testing already performed for these changes:
Added new unit tests. Fixed use case to run without error
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review TCDiag basic use case and confirm that output is expected and scientifically useful
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [Yes]
The TCDiag basic use case will likely have different results and will require the truth data to be recreated.
[X] Please complete this pull request review by 1/5/2024.
[X] Review the source issue metadata (required labels, projects, and milestone).
[X] Complete the PR definition above.
[X] Ensure the PR title matches the feature or bugfix branch name.
[X] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
These are changes to match the changes to the MET tool. See issue #2432 for details.
Pull Request Testing
Added new unit tests. Fixed use case to run without error
Review TCDiag basic use case and confirm that output is expected and scientifically useful
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [Yes] The TCDiag basic use case will likely have different results and will require the truth data to be recreated.
[X] Please complete this pull request review by 1/5/2024.
Pull Request Checklist
See the METplus Workflow for details.