dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
97 stars 37 forks source link

Feature dtcenter/MET#2796 develop - Fix error log artifact creation #2475

Closed georgemccabe closed 7 months ago

georgemccabe commented 7 months ago

I had to include complicated logic to check if any jobs that save error logs ran successfully to determine if error log artifacts should be merged.

Pull Request Testing

Ran a few test runs to ensure correct behavior occurs: https://github.com/dtcenter/METplus/actions/runs/7659713325 - doesn't run merge because no cases had errors https://github.com/dtcenter/METplus/actions/runs/7661855137 - some use cases failed and error_logs was created https://github.com/dtcenter/METplus/actions/runs/7661220745 - all use case succeeded but had diffs - no error_logs should be created/merged

Review code changes

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7662047088


Totals Coverage Status
Change from base Build 7645730422: 0.0%
Covered Lines: 8508
Relevant Lines: 9374

💛 - Coveralls
georgemccabe commented 7 months ago

The logs are already stored in the output for each use case group. It was cumbersome to have to download the full output for a use case group to get the logs for a single failure, so I set up logic to copy over logs for use cases that have any errors to create a separate artifact that is smaller in size and easier to download.