feature #2253 fix empty pytest logs

John-Sharples commented 8 months ago

Pull Request Testing

[x] Describe testing already performed for these changes:
I have run the tests with and without this change to compare log file outputs. Appears to now write logged content to file.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Run tests and check output
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? Yes
[x] Do these changes include sufficient testing updates? Yes
[x] Will this PR result in changes to the test suite? Yes
If yes, describe the new output and/or changes to the existing output:
[x] Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

[x] Add any new Python packages to the METplus Components Python Requirements table.
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow. Select: @georgemccabe Select: METplus-Wrappers-6.0.0 Development Select: METplus-6.0.0
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7793212853

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.762%

Totals
Change from base Build 7700714846:	0.0%
Covered Lines:	8508
Relevant Lines:	9374

💛 - Coveralls

John-Sharples commented 8 months ago

@georgemccabe

The mock simply calls config.logger with whatever args were passed to the mock, so it should just use the format specified by config. I had a quick dig to see where the formatting was coming from for the tests. It appears differnet tests use different configs, which are in several places within internal/tests/pytests/utils.

For example, changing this LOG_LINE_FORMAT changed the log output for tests using that config file.

dtcenter / METplus