dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
94 stars 37 forks source link

Feature #2406 redo usecase rrfs #2488

Closed bikegeek closed 5 months ago

bikegeek commented 5 months ago

Describe testing already performed for these changes:

on 'seneca':

used this environment: /home/met_test/miniforge3/envs/rrfs_usecase_env

run from bash shell

run: activate /home/met_test/miniforge3/envs/rrfs_usecase_env

created a working directory and under this directory:
- cloned the develop branch of METdataio
- cloned the develop branch of METcalcpy
- cloned the develop branch of METplotpy
- cloned the feature_2406_usecase_RRFS branch of METplus

set up the [usecase_setup.sh.txt](https://github.com/dtcenter/METplus/files/14149406/usecase_setup.sh.txt):
    save in the WORKING_DIR
    remove .txt extension (this was required to save here)
    set WORKING_DIR environment value in the script
    run: source usecase_setup.sh

Downloaded [sample_data-short_range.tgz](https://dtcenter.ucar.edu/dfiles/code/METplus/METplus_Data/feature_2406_usecase_RRFS/sample_data-short_range.tgz) from:
    https://dtcenter.ucar.edu/dfiles/code/METplus/METplus_Data/feature_2406_usecase_RRFS/
    NOTE: Followed instructions for adding data, but the tar file is not appearing in the METplus_Data/v5.1 or v6.0 directory
    for keeping things together, unzip'd and untar'd under the $WORKING_DIR

set up the [user.conf.txt](https://github.com/dtcenter/METplus/files/14149435/user.conf.txt) file for the user system config file:
    saved to $WORKING_DIR
    remove .txt extension (only needed to load file here)
    using the path to MET on 'seneca'

run the use case:
    from anywhere:
    python $METPLUS_BASE/ush/run_metplus.py $METPLUS_BASE/parm/use_cases/model_applications/short_range/UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot.conf $WORKING_DIR/user.conf

Verify that a reformatted file was created in the $METPLUS_BASE/output/reformatted directory:
    ensemble_stat_ecnt.data

Verify that an aggregation statistics file was created in the $METPLUS_BASE/output/aggregated directory:
    ecnt_aggregated.data

Check that a spread-skill was created in the $METPLUS_BASE/output/plot directory and view it, it should look like this:

short-range_UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot

Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Perform same steps above

Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Do these changes include sufficient testing updates? [Yes] Added this use case to the tests in the workflow

Will this PR result in changes to the test suite? [Yes]

Additional data files in the sample_data-short_range.tgz tarball

Please complete this pull request review by [COB Monday February 5].

Pull Request Checklist

See the METplus Workflow for details.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 7819858366


Totals Coverage Status
Change from base Build 7818836051: 0.0%
Covered Lines: 8508
Relevant Lines: 9374

💛 - Coveralls