by getting the real path of the script before trying to find the directory above the script to import metplus and produtil
Pull Request Testing
[X] Describe testing already performed for these changes:
Created sym link to run_metplus.py in another directory and confirmed that it failed using develop (cannot import produtil). Confirmed that it works with the fix.
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Confirm that this fix resolved the issue you experienced.
Ensure that all automated tests pass
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
[X] Do these changes include sufficient testing updates? [Yes]
We could consider adding a test that creates a sym link to run_metplus.py and tries to call it from there.
[X] Will this PR result in changes to the test suite? [No]
There are diffs from a previous change that will likely flag diffs in this PR, but they can be resolved once the truth data is updated.
[X] Please complete this pull request review by 2/16/2024.
[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
by getting the real path of the script before trying to find the directory above the script to import metplus and produtil
Pull Request Testing
Created sym link to run_metplus.py in another directory and confirmed that it failed using develop (cannot import produtil). Confirmed that it works with the fix.
Confirm that this fix resolved the issue you experienced. Ensure that all automated tests pass
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
[X] Do these changes include sufficient testing updates? [Yes]
We could consider adding a test that creates a sym link to run_metplus.py and tries to call it from there.
There are diffs from a previous change that will likely flag diffs in this PR, but they can be resolved once the truth data is updated.
Pull Request Checklist
See the METplus Workflow for details.