[x] Describe testing already performed for these changes:
Tested the 2 new use cases to be sure they run. The documentation has also been updated and that has been checked.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Run the two use cases that are new. One use case (UserScript_fcstGFS_obsERA_StratosphereBias) runs successfully in GitHub actions. The other use case (UserScript_fcstGFS_obsERA_StratospherePolar) cannot be run in GitHub actions as it runs out of disk space Information on running the use cases is listed here:
UserScript_fcstGFS_obsERA_StratosphereBias:
The data for this use case is 2 files available on derecho, /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias/ERA_2018_02.nc and /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias/GFS_2018_02_024h.nc
To run the use case, the develop branch of METcalcpy, METplotpy and METdataio are needed, as well as the feature_1344_stratosphere_bias branch of METplus. Run model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias.conf. The output should match the 2 plots located on derecho:/glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias/plots
Note that python embedding is not working on derecho, so this use case will need to be run on another machine for it to work.
UserScript_fcstGFS_obsERA_StratospherePolar:
The data for this use case is in 2 directories on derecho, /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar/ERA and /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar/GFS
To run the use case, the develop branch of METcalcpy, METplotpy and METdataio are needed, as well as the feature_1344_stratosphere_bias branch of METplus. Run model_applications/s2s/UserScript_fcstGFS_obsERA_StratospherePolar.conf. The output should match the 4 plots located on derecho:/glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar/plots
[x] Do these changes include sufficient testing updates? [Yes or No]
Yes
[x] Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Yes. One new use case has been added to the GitHub actions tests
[x] Please complete this pull request review by [Fill in date].
03/04/2024
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
[x] Describe testing already performed for these changes: Tested the 2 new use cases to be sure they run. The documentation has also been updated and that has been checked.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Run the two use cases that are new. One use case (UserScript_fcstGFS_obsERA_StratosphereBias) runs successfully in GitHub actions. The other use case (UserScript_fcstGFS_obsERA_StratospherePolar) cannot be run in GitHub actions as it runs out of disk space Information on running the use cases is listed here:
UserScript_fcstGFS_obsERA_StratosphereBias: The data for this use case is 2 files available on derecho, /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias/ERA_2018_02.nc and /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias/GFS_2018_02_024h.nc To run the use case, the develop branch of METcalcpy, METplotpy and METdataio are needed, as well as the feature_1344_stratosphere_bias branch of METplus. Run model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias.conf. The output should match the 2 plots located on derecho:/glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias/plots Note that python embedding is not working on derecho, so this use case will need to be run on another machine for it to work.
UserScript_fcstGFS_obsERA_StratospherePolar: The data for this use case is in 2 directories on derecho, /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar/ERA and /glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar/GFS To run the use case, the develop branch of METcalcpy, METplotpy and METdataio are needed, as well as the feature_1344_stratosphere_bias branch of METplus. Run model_applications/s2s/UserScript_fcstGFS_obsERA_StratospherePolar.conf. The output should match the 4 plots located on derecho:/glade/derecho/scratch/kalb/Stratosphere/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar/plots
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No] Yes. The documentation can be viewed here: https://metplus.readthedocs.io/en/feature_1344_stratosphere_bias/generated/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereBias.html#sphx-glr-generated-model-applications-s2s-stratosphere-userscript-fcstgfs-obsera-stratospherebias-py https://metplus.readthedocs.io/en/feature_1344_stratosphere_bias/generated/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratospherePolar.html#sphx-glr-generated-model-applications-s2s-stratosphere-userscript-fcstgfs-obsera-stratospherepolar-py
[x] Do these changes include sufficient testing updates? [Yes or No] Yes
[x] Will this PR result in changes to the test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output: Yes. One new use case has been added to the GitHub actions tests
[x] Please complete this pull request review by [Fill in date]. 03/04/2024
Pull Request Checklist
See the METplus Workflow for details.