dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
94 stars 37 forks source link

Remove the `TC_RMW_MAX_RANGE_KM` configuration option #2513

Closed JohnHalleyGotway closed 1 month ago

JohnHalleyGotway commented 4 months ago

Describe the Task

The dtcenter/MET#2833 bugfix proposes 2 changes that may impact the METplus wrappers repo:

  1. Removing the max_range_km configuration option from the TC-RMW configuration file means that the corresponding METplus TC_RMW_MAX_RANGE_KM configuration option should also be removed. Note that this includes removing it from the wrapped TC-RMW MET config file.
  2. Changing the default setting for rmw_scale from 0.2 to NA means that, by default, the range/azimuth grid will be defined by the delta_range_km config option rather than the rmw_scale option. Setting rmw_scale to a non-NA value takes precedence over the delta_range_km option and overrides this default behavior.

Note that off-by-one bugs exist in defining both the range and azimuth values for both TC-RMW and TC-Diag. Fixing these bugs will lead to changes in the METplus output for any calls to TC-RMW or TC-Diag.

PR dtcenter/MET#2840 for issue dtcenter/MET#2833 was merged into develop on 3/27/24 during the beta4 development cycle. This METplus issue can be fixed during either the beta4 or beta5 development cycles. Please re-schedule as needed.

You only need to make this change for the develop branch. In my opinion, no change is needed in a METplus-5.1 bugfix release since having an extra unused configuration option does not cause any harm.

Time Estimate

2 hours?

Sub-Issues

Consider breaking the task down into sub-issues. None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

Labels

Projects and Milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

georgemccabe commented 1 month ago

This work was completed as part of PR #2606. When that PR is merged, this issue can be closed.