[X] Describe testing already performed for these changes:
Recreated the bug described in issue #2520. Confirmed that the bug was resolved independently from both fixes to ascii2nc_wrapper.py and changes to deprecated variable check that prevents redundant wrapper initialization.
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Test use case that discovered this issue and confirm that it now runs without issue.
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
I removed the optional file window variables from the ASCII2NC basic use case so the use case can be used as a test that it will run without issue when those values are not set.
[X] Will this PR result in changes to the test suite? [No]
[X] Please complete this pull request review by 3/25/2024.
[X] Review the source issue metadata (required labels, projects, and milestone).
[X] Complete the PR definition above.
[X] Ensure the PR title matches the feature or bugfix branch name.
[X] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Pull Request Testing
Recreated the bug described in issue #2520. Confirmed that the bug was resolved independently from both fixes to ascii2nc_wrapper.py and changes to deprecated variable check that prevents redundant wrapper initialization.
Test use case that discovered this issue and confirm that it now runs without issue.
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
I removed the optional file window variables from the ASCII2NC basic use case so the use case can be used as a test that it will run without issue when those values are not set.
[X] Will this PR result in changes to the test suite? [No]
[X] Please complete this pull request review by 3/25/2024.
Pull Request Checklist
See the METplus Workflow for details.