dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
94 stars 37 forks source link

Update develop-ref after dtcenter/MET#2849 #2552

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 3 months ago

dtcenter/MET#2849 changed the value of the '-boot_interval' job argument from a number to a string
Created by @georgemccabe

From @JohnHalleyGotway on Slack:

George, thanks for the heads up. The difference I see is -boot_interval 2 changing to -boot_interval PCTILE. It was caused by the change to line 2823 of stat_job.cc. OLD: js << "-boot_interval " << boot_interval << " "; NEW: js << "-boot_interval " << bootintervaltype_to_string(boot_interval) << " "; I think I’m the person who made this change. Instead of writing out the enumerated integer value, we’re writing the corresponding string.

So yes, this is a good change to the output… although I would say that the diffs it caused were “unanticipated”. But please consider any diffs to -boot_interval in .out files to be acceptable diffs.