dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
97 stars 37 forks source link

New Use Case: Add a use case (or use cases) demonstrating the UGRID functionality in MET #2576

Open DanielAdriaansen opened 5 months ago

DanielAdriaansen commented 5 months ago

Describe the New Use Case

After the updates to GridStat and PointStat in MET to support unstructured grids, we should implement a new use case demonstrating the verification of some of the sample FCST data we received for testing in the METplus Wrappers repository.

The tests that we used during MET development included:

  1. Verify significant wave height from GLWU wave model from EMC/NOAA using buoy data (PointStat)
  2. Verify LFRIC 2D 10m U-wind using ADPSFC PREPBUFR Uwind (PointStat)
  3. Verify MPAS post-processed diagnostic temperature at 500 hPa using ADPUPA Temperature from PREPBUFR (PointStat)

We could consider a new Model Applications use case category for "UGRID", or put these where they fit otherwise (e.g. #1 would go under "marine and cryosphere").

Use Case Name and Category

Provide use case name, following Contributor's Guide naming template, and list which category the use case will reside in. If a new category is needed for this use case, provide its name and brief justification

Input Data

List input data types and sources. Provide a total input file size, keeping necessary data to a minimum.

Acceptance Testing

Describe tests required for new functionality. As use case develops, provide a run time here

Time Estimate

Approximately 2 days of work for @DanielAdriaansen.

Sub-Issues

Consider breaking the new feature down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

Labels

Projects and Milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

New Use Case Checklist

See the METplus Workflow for details.

AliciaBentley-NOAA commented 4 months ago

@JohnHalleyGotway @DanielAdriaansen Here is a METplus issue related to adding "Unstructured Grids" in METplus-6.0.0 (along with MET issues https://github.com/dtcenter/MET/issues/2746 and https://github.com/dtcenter/MET/issues/2860) . Does this particular METplus issue also need to be finished in order for Unstructured grids to be added to METplus-6.0.0? If this issue is required in order to add unstructured grids, can it please be marked as a blocker to the METplus-6.0.0 official release? Thank you!

AliciaBentley-NOAA commented 4 months ago

@j-opatz @georgemccabe Here is a METplus issue related to adding "Unstructured Grids" in METplus-6.0.0 (along with MET issues https://github.com/dtcenter/MET/issues/2746 and https://github.com/dtcenter/MET/issues/2860) . Does this particular METplus issue also need to be finished in order for Unstructured grids to be added to METplus-6.0.0? If this issue is required in order to add unstructured grids, can it please be marked as a blocker to the METplus-6.0.0 official release? Thank you!

georgemccabe commented 4 months ago

Hi @AliciaBentley-NOAA, unless there is a specific requirement to provide a METplus use case demonstrating the use of the new unstructured grid functionality, I don't think this issue necessarily required. The new unstructured grid read capabilities can still be used without an example. That said, it is very useful for users to have a concrete example. I think it would be worthwhile to finish this task while the details are fresh, but it isn't preventing the functionality from being available to users in METplus 6.0.0.

AliciaBentley-NOAA commented 4 months ago

@georgemccabe Thank you for clarifying! If this is not required to have this functionality in METplus-6.0.0, then I agree that it actually doesn't need to be marked as required for the official release. Thanks!