Bugfix #2567 PointStat multiple point observation files

[georgemccabe]

Pull Request Testing

• [X] Describe testing already performed for these changes:
  

Ran I-WRF Hurricane Matthew use case and confirmed that observation files are read properly after fix was applied.

Before bugfix:

module load apptainer

cd ${SCRATCH}
apptainer pull docker://dtcenter/metplus:6.0.0-beta4

LOCAL_METPLUS_CONFIG_DIR=/glade/u/home/mccabe/i-wrf/use_cases/Hurricane_Matthew/METplus
LOCAL_FCST_INPUT_DIR=/glade/derecho/scratch/jaredlee/nsf_i-wrf/matthew
LOCAL_UPPER_AIR_OBS_INPUT_DIR=/glade/campaign/ral/wsap/i-wrf/data/hurr-matthew/madis/point/raob/netcdf
LOCAL_SURFACE_OBS_INPUT_DIR=/glade/campaign/ral/wsap/i-wrf/data/hurr-matthew/madis/point/metar/netcdf
LOCAL_OUTPUT_DIR=${SCRATCH}/metplus_out_bug

export APPTAINER_BIND="${LOCAL_METPLUS_CONFIG_DIR}:/config,${LOCAL_FCST_INPUT_DIR}:/data/input/wrf,${LOCAL_UPPER_AIR_OBS_INPUT_DIR}:/data/input/obs/raob,${LOCAL_SURFACE_OBS_INPUT_DIR}:/data/input/obs/metar,${LOCAL_OUTPUT_DIR}:/data/output"

apptainer exec metplus_6.0.0-beta4.sif /metplus/METplus/ush/run_metplus.py /config/PointStat_matthew.conf

After bugfix:

module load apptainer

cd ${SCRATCH}
apptainer pull docker://dtcenter/metplus-dev:bugfix_2567_develop_point_stat_multi_obs-pull_request

LOCAL_METPLUS_CONFIG_DIR=/glade/u/home/mccabe/i-wrf/use_cases/Hurricane_Matthew/METplus
LOCAL_FCST_INPUT_DIR=/glade/derecho/scratch/jaredlee/nsf_i-wrf/matthew
LOCAL_UPPER_AIR_OBS_INPUT_DIR=/glade/campaign/ral/wsap/i-wrf/data/hurr-matthew/madis/point/raob/netcdf
LOCAL_SURFACE_OBS_INPUT_DIR=/glade/campaign/ral/wsap/i-wrf/data/hurr-matthew/madis/point/metar/netcdf
LOCAL_OUTPUT_DIR=${SCRATCH}/metplus_out

export APPTAINER_BIND="${LOCAL_METPLUS_CONFIG_DIR}:/config,${LOCAL_FCST_INPUT_DIR}:/data/input/wrf,${LOCAL_UPPER_AIR_OBS_INPUT_DIR}:/data/input/obs/raob,${LOCAL_SURFACE_OBS_INPUT_DIR}:/data/input/obs/metar,${LOCAL_OUTPUT_DIR}:/data/output"

apptainer exec metplus-dev_bugfix_2567_develop_point_stat_multi_obs-pull_request.sif /metplus/METplus/ush/run_metplus.py /config/PointStat_matthew.conf

• [X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Review log output on casper to confirm that bug is reconciled with changes.

Before fix: /glade/derecho/scratch/mccabe/metplus_out_bug/logs/metplus.log.20240514154608 After fix: /glade/derecho/scratch/mccabe/metplus_out/logs/metplus.log.20240514150921

• [X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• [X] Do these changes include sufficient testing updates? [Yes]

• [X] Will this PR result in changes to the test suite? [No]
  If yes, describe the new output and/or changes to the existing output:
  

• [X] Do these changes introduce new SonarQube findings? [No]
  If yes, please describe:

• [X] Please complete this pull request review by 5/15/2024.
  

Pull Request Checklist

See the METplus Workflow for details.

• [X] Add any new Python packages to the METplus Components Python Requirements table.
• [X] Review the source issue metadata (required labels, projects, and milestone).
• [X] Complete the PR definition above.
• [X] Ensure the PR title matches the feature or bugfix branch name.
• [X] Define the PR metadata, as permissions allow. Select: Reviewer(s) Select: Organization level software support Project or Repository level development cycle Project Select: Milestone as the version that will include these changes
• [X] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.