Feature #2479 time_offset_warning

[georgemccabe]

Pull Request Testing

• [X] Describe testing already performed for these changes:
  

Added unit tests and ran ASCII2NC.conf basic use case to confirm that adding config.TIME_OFFSET_WARNING=3 and config.ASCII2NC_TIME_OFFSET_WARNING=3 both properly set the environment variable referenced in the wrapped ASCII2NC MET config file.

• [X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Review code changes

• Review documentation changes. https://metplus.readthedocs.io/en/feature_2479_time_offset_warning/Users_Guide/wrappers.html https://metplus.readthedocs.io/en/feature_2479_time_offset_warning/Users_Guide/glossary.html

• Confirm all tests pass.

• [X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• [X] Do these changes include sufficient testing updates? [Yes]

• [X] Will this PR result in changes to the test suite? [No]
  If yes, describe the new output and/or changes to the existing output:
  

• [X] Do these changes introduce new SonarQube findings? [No]
  If yes, please describe:

• [X] Please complete this pull request review by 5/17/2024.
  

Pull Request Checklist

See the METplus Workflow for details.

• [X] Add any new Python packages to the METplus Components Python Requirements table.
• [X] Review the source issue metadata (required labels, projects, and milestone).
• [X] Complete the PR definition above.
• [X] Ensure the PR title matches the feature or bugfix branch name.
• [X] Define the PR metadata, as permissions allow. Select: Reviewer(s) Select: Organization level software support Project or Repository level development cycle Project Select: Milestone as the version that will include these changes
• [x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

Hi @georgemccabe. I see there is one failing test. Is the land_surface use case tests failure expected?

[georgemccabe]

@jprestop, the land surface use case difference is unrelated to these changes. @DanielAdriaansen and @JohnHalleyGotway are aware and are investigating.