dtcenter / METplus

Python scripting infrastructure for MET tools.
https://metplus.readthedocs.io
Apache License 2.0
92 stars 36 forks source link

Feature #1514 MADIS2NC wrapper #2591

Closed georgemccabe closed 1 month ago

georgemccabe commented 1 month ago

Unrelated changes in this PR:

Pull Request Testing

Added unit tests, ran new basic use case

Added unit tests and basic use case

The new MADIS2NC basic use case will produce new output that will require the truth data to be updated. We will need to coordinate with @DanielAdriaansen and @JohnHalleyGotway to determine if the land_surface:0 should be disabled until it can be fixed before updating the truth data.

Pull Request Checklist

See the METplus Workflow for details.

georgemccabe commented 1 month ago

I noticed the SonarQube scan failed because it didn't like my new unit tests that are very similar to the tests for ASCII2NC. I'm working on a solution to use a pytest fixture to remove some of the redundant test code in the pytests for each wrapper to resolve this.