Closed georgemccabe closed 1 month ago
I noticed the SonarQube scan failed because it didn't like my new unit tests that are very similar to the tests for ASCII2NC. I'm working on a solution to use a pytest fixture to remove some of the redundant test code in the pytests for each wrapper to resolve this.
Unrelated changes in this PR:
Pull Request Testing
Added unit tests, ran new basic use case
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Confirm all automated tests pass (except land_surface:0 which is failing to an unrelated issue)
Review new use case documentation: https://metplus.readthedocs.io/en/feature_1514_madis2nc/generated/met_tool_wrapper/MADIS2NC/MADIS2NC.html
Review new Contributor's Guide content (if time permits): https://metplus.readthedocs.io/en/feature_1514_madis2nc/Contributors_Guide/create_wrapper.html
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
Added unit tests and basic use case
The new MADIS2NC basic use case will produce new output that will require the truth data to be updated. We will need to coordinate with @DanielAdriaansen and @JohnHalleyGotway to determine if the land_surface:0 should be disabled until it can be fixed before updating the truth data.
[X] Do these changes introduce new SonarQube findings? [No] If yes, please describe:
[X] Please complete this pull request review by 5/20/2024.
Pull Request Checklist
See the METplus Workflow for details.