PR dtcenter/MET#2892 for issue dtcenter/MET#2395 adds a new TOTAL_DIR column to the VL1L2, VAL1L2, and VCNT line types. This will impact the output of all METplus use cases that process vector winds.
[x] Link to relevant issue(s): dtcenter/MET#2395
[x] Link to relevant pull request(s): dtcenter/MET#2892
Define the Metadata
Title
[x] Define the Title of this issue as Update Truth: For dtcenter/{REPO}#{PR_NUMBER} to indicate the repository and pull request that warranted this issue.
Assignee
Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.
[x] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required
Milestone and Projects
[x] Select Milestone as the next official version if updating truth data for the develop branch OR select next METplus-Wrappers-X.Y.Z bugfix version if updating truth data for a main_vX.Y branch.
[x] If updating truth data for the develop branch, select the METplus-Wrappers-X.Y.Z Development project OR if updating truth for a main_vX.Y branch, select the Coordinated METplus-X.Y Support project
Update Truth Checklist
[ ] Review the GitHub Actions workflow that was triggered by the PR merge
If no differences were found, note this in a comment.
If all of the differences are expected, note this in a comment.
Include any details of how the review was performed.
If unexpected differences are found, the following instructions can
help uncover potential explanations. If none of these apply and the
source of the differences cannot be determined, contact the
METplus wrappers lead engineer (@georgemccabe) for assistance.
Search for other open issues that have the label type: update truth
applied by clicking on the label on this issue. Coordinate with the
author of these issues to ensure all diffs are properly reviewed.
Check if any additional GitHub Actions testing workflows have been
triggered since the workflow that corresponds to this issue was run.
Review the latest run to ensure that there are no diffs that are
unrelated to this issue.
If the incorrect differences are caused by the changes from the
issue that warranted this issue, consider reverting the PR and
re-opening the issue.
Iterate until one of the above conditions apply.
[ ] Approve the update of the truth data
Contact the METplus wrappers lead engineer (@georgemccabe) or
backup lead (@jprestop) to let them know that the truth data can
be updated.
Describe Expected Changes
PR dtcenter/MET#2892 for issue dtcenter/MET#2395 adds a new
TOTAL_DIRcolumn to the VL1L2, VAL1L2, and VCNT line types. This will impact the output of all METplus use cases that process vector winds.Define the Metadata
Title
Assignee
Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.
Milestone and Projects
developbranch OR select next METplus-Wrappers-X.Y.Z bugfix version if updating truth data for amain_vX.Ybranch.developbranch, select the METplus-Wrappers-X.Y.Z Development project OR if updating truth for amain_vX.Ybranch, select the Coordinated METplus-X.Y Support projectUpdate Truth Checklist
type: update truthapplied by clicking on the label on this issue. Coordinate with the author of these issues to ensure all diffs are properly reviewed.