In addition to adding support for setting -valid_beg and -valid_end in the ASCII2NC wrapper, the following enhancements were made in this pull request:
Created ReformatPointWrapper to hold common functionality for similar wrappers that reformat point observation data (ASCII2NC, MADIS2NC, PB2NC, and Point2Grid). This simplifies the logic in each of the wrappers
Modified all find_input_files functions to be consistent by returning a time_info dictionary or None on failure
Refactored preprocess_file function to satisfy SonarQube and properly apply quotation marks around an input that contains spaces, e.g. python embedding script calls with arguments or grid specification strings, so that it doesn't need to be handled downstream
Pull Request Testing
[X] Describe testing already performed for these changes:
Added/updated unit tests, ensured that all existing use cases produce the same results
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes
Check that all automated tests pass
Review results from test on seneca /d1/projects/METplus/pull_requests/METplus-6.0.0/pr_2606. This directory includes:
METplus directory on branch feature_2547_ascii2nc_valid_beg_end
ASCII2NC.conf copied from basic use case and added ASCII2NC_VALID_BEG and ASCII2NC_VALID_END values (ASCII2NC_VALID_BEG = {valid?fmt=%Y%m%d_%H?shift=-1H} and ASCII2NC_VALID_END = {valid?fmt=%Y%m%d_%H?shift=1H})
run_test.sh script that was used to run use case
test.log file that contains terminal output from use case run
out directory that contains use case output
[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[X] Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
[X] Please complete this pull request review by 5/11/2024.
[X] Review the source issue metadata (required labels, projects, and milestone).
[X] Complete the PR definition above.
[X] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
[X] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
In addition to adding support for setting
-valid_beg
and-valid_end
in the ASCII2NC wrapper, the following enhancements were made in this pull request:Pull Request Testing
Added/updated unit tests, ensured that all existing use cases produce the same results
[X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes
Check that all automated tests pass
Review results from test on seneca
/d1/projects/METplus/pull_requests/METplus-6.0.0/pr_2606
. This directory includes:METplus
directory on branchfeature_2547_ascii2nc_valid_beg_end
ASCII2NC.conf
copied from basic use case and added ASCII2NC_VALID_BEG and ASCII2NC_VALID_END values (ASCII2NC_VALID_BEG = {valid?fmt=%Y%m%d_%H?shift=-1H}
andASCII2NC_VALID_END = {valid?fmt=%Y%m%d_%H?shift=1H}
)run_test.sh
script that was used to run use casetest.log
file that contains terminal output from use case runout
directory that contains use case output[X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[X] Do these changes include sufficient testing updates? [Yes]
[X] Will this PR result in changes to the test suite? [No] If yes, describe the new output and/or changes to the existing output:
[X] Do these changes introduce new SonarQube findings? [No] If yes, please describe:
[X] Please complete this pull request review by 5/11/2024.
Pull Request Checklist
See the METplus Workflow for details.