Feature #2578 PCPCombine -input_thresh for missing inputs

[georgemccabe]

Additional Changes

• Added support for setting -vld_thresh argument using FCST_PCP_COMBINE_VLD_THRESH or OBS_PCP_COMBINE_VLD_THRESH.
• Added version number to terminal output from usage statement

Pull Request Testing

• [X] Describe testing already performed for these changes:
  

Added unit tests to test new behavior.

• [X] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Review code changes Ensure all automated tests pass (except short_range:10-12 which is an unrelated known failure)

• [X] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• [X] Do these changes include sufficient testing updates? [Yes]

• [X] Will this PR result in changes to the test suite? [No]
  If yes, describe the new output and/or changes to the existing output:
  

• [X] Do these changes introduce new SonarQube findings? [No]
  If yes, please describe:

• [X] Please complete this pull request review by 6/13/2024.
  

Pull Request Checklist

See the METplus Workflow for details.

• [X] Add any new Python packages to the METplus Components Python Requirements table.
• [X] For any new datasets, an entry to the METplus Verification Datasets Guide.
• [X] Review the source issue metadata (required labels, projects, and milestone).
• [X] Complete the PR definition above.
• [X] Ensure the PR title matches the feature or bugfix branch name.
• [x] Define the PR metadata, as permissions allow. Select: Reviewer(s) and Development issue Select: Milestone as the version that will include these changes Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
• [x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

@georgemccabe I see updates to the prune_emtpy(...) in these changes for checking for and removing files that are empty... i.e. have file size of 0. Is this actually needed for this issue or just somewhat related?

I can imagine that whether or not empty files appear in a file list could have a potentially large impact on functionality. But it's only applied when prune_empty(...) is called.

How often is that called? Do you see a potential for unexpected behavior here? Or is this all working as it should?

[georgemccabe]

The prune_empty function is currently only called by ExtractTiles wrapper. I think it is no longer needed, as the wrapper has since been refactored and shouldn't produce any empty files. I can remove it to see if it has any impact on any use cases and add it back in if it is actually needed. The changes here involved creating a function to traverse through a directory and replacing any logic that does that to call the function instead.

@georgemccabe I see updates to the prune_emtpy(...) in these changes for checking for and removing files that are empty... i.e. have file size of 0. Is this actually needed for this issue or just somewhat related?

I can imagine that whether or not empty files appear in a file list could have a potentially large impact on functionality. But it's only applied when prune_empty(...) is called.

How often is that called? Do you see a potential for unexpected behavior here? Or is this all working as it should?