Closed JohnHalleyGotway closed 1 week ago
This review is based on this GHA testing workflow run that was triggered when PR dtcenter/MET#2921 was merged into develop.
I note the following:
Archive: diff-use_cases_met_tool_wrapper_0-29_59-64.zip
inflating: met_tool_wrapper/TCDiag/tc_diag/2023/sal032023_gfso_doper_2023062012_cyl_grid_parent_output.nc
inflating: met_tool_wrapper/TCDiag/tc_diag/2023/sal032023_gfso_doper_2023062012_cyl_grid_parent_truth.nc
inflating: met_tool_wrapper/TCDiag/tc_diag/2023/sal032023_gfso_doper_2023062012_diag_output.nc
inflating: met_tool_wrapper/TCDiag/tc_diag/2023/sal032023_gfso_doper_2023062012_diag_truth.nc
Archive: diff-use_cases_met_tool_wrapper_30-58.zip
inflating: met_tool_wrapper/TCRMW/met_tool_wrapper/TCRMW/tc_rmw_aal142016_output.nc
inflating: met_tool_wrapper/TCRMW/met_tool_wrapper/TCRMW/tc_rmw_aal142016_truth.nc
Archive: diff-use_cases_tc_and_extra_tc_0-2.zip
inflating: tc_and_extra_tc/TCRMW_fcstGFS_fcstOnly_gonzalo/model_applications/tc_and_extra_tc/TCRMW_gonzalo/tc_rmw_gonzal09l.2014101312_output.nc
inflating: tc_and_extra_tc/TCRMW_fcstGFS_fcstOnly_gonzalo/model_applications/tc_and_extra_tc/TCRMW_gonzalo/tc_rmw_gonzal09l.2014101312_truth.nc
I used ncview
to spot check the 4th file and see the differences are exactly as expected with the range/azimuth data shift to the right by 90 degrees (north to east) and then reversed (counterclockwise to clockwise):
I also see the same pattern in the first diff file.
I'll also note that no differences were flagged in the TC-Diag .dat
output file: met_tool_wrapper/TCDiag/tc_diag/2023/sal032023_gfso_doper_2023062012_diag.dat
. This makes sense because the diagnostics are computed for each RANGE value and the modified azimuths should still produce the same average value for each range. However, the 850TANG
, 850VORT
, and 200DVRG
diagnostics are reported as bad data in the output... and those are based on the derivation radial and tangential wind derivations. We should eventually have a TC-Diag use case that actually computes those diagnostic values from the radial/tangential winds (@jvigh and @KathrynNewman).
850TANG (10M/S) 9999 9999 9999
850VORT (/S) 9999 9999 9999
200DVRG (/S) 9999 9999 9999
Describe Expected Changes
PR dtcenter/MET#2921 for issue dtcenter/MET#2841 modifies the definition of the range/azimuth grids used by the TC-RMW and TC-Diag tools. It makes the following changes:
This will cause all TC-RMW and TC-Diag outputs based on the range/azimuth grid definitions to be modified. Specifically, we should see a phase shift in the data (i.e. shifting left by 25% due to the north to east change) as well as a reversal of values along the X-axis due to changing from counterclockwise to clockwise.
Define the Metadata
Title
Assignee
Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.
Milestone and Projects
develop
branch OR select next METplus-Wrappers-X.Y.Z bugfix version if updating truth data for amain_vX.Y
branch.develop
branch, select the METplus-Wrappers-X.Y.Z Development project OR if updating truth for amain_vX.Y
branch, select the Coordinated METplus-X.Y Support projectUpdate Truth Checklist
type: update truth
applied by clicking on the label on this issue. Coordinate with the author of these issues to ensure all diffs are properly reviewed.