[x] Describe testing already performed for these changes:
Tested the use case to be sure it works as expected with no errors and produces reasonable output
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
There are 3 suggested things to review/test:
Test the use case, UserScript_fcstGFS_obsERA_StratosphereQBO in the s2s_stratosphere area. To run this use case, you will need multiple repositories listed below, and they will need to be in your python path or conda environment. The use case cannot be run in GitHub actions due to it's size, so data can be found in the additional_data_UserScript_fcstGFS_obsERA_StratosphereQBO.tar.gz file located at https://dtcenter.ucar.edu/dfiles/code/METplus/METplus_Data/v6.0/. The output from this use case should be the same as what is seen on derecho:/glade/derecho/scratch/kalb/Stratosphere_QBO/METplus/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereQBO in the mpr, plots, and StatAnalysis directories. I can put this sample output somewhere else if it's easier, for comparison
Repositories needed
METplus, feature_2557_stratosphere_qbo branch
METdataio, develop branch
METplotpy, feature_447_stratosphere_qbo
METcalcpy, feature_385_stratosphere_qbo branch
Check to be sure there are no errors in actions for the Blocking and weather regime use cases. The write_mpr program was changed in METcalcpy, which is used in UserScript_fcstGFS_obsERA_Blocking and UserScript_fcstGFS_obsERA_WeatherRegime, both in the s2s_mid_lat area
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Yes
[x] Do these changes include sufficient testing updates? [Yes or No]
??
[x] Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
No
[x] Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
No
[x] Please complete this pull request review by [Fill in date].
6/29/2024
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
[x] Describe testing already performed for these changes: Tested the use case to be sure it works as expected with no errors and produces reasonable output
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: There are 3 suggested things to review/test:
The documentation for this use case can be viewed here: https://metplus.readthedocs.io/en/feature_2557_stratosphere_qbo/generated/model_applications/s2s_stratosphere/UserScript_fcstGFS_obsERA_StratosphereQBO.html#sphx-glr-generated-model-applications-s2s-stratosphere-userscript-fcstgfs-obsera-stratosphereqbo-py
Check to be sure there are no errors in actions for the Blocking and weather regime use cases. The write_mpr program was changed in METcalcpy, which is used in UserScript_fcstGFS_obsERA_Blocking and UserScript_fcstGFS_obsERA_WeatherRegime, both in the s2s_mid_lat area
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No] Yes
[x] Do these changes include sufficient testing updates? [Yes or No] ??
[x] Will this PR result in changes to the test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output: No
[x] Do these changes introduce new SonarQube findings? [Yes or No] If yes, please describe: No
[x] Please complete this pull request review by [Fill in date]. 6/29/2024
Pull Request Checklist
See the METplus Workflow for details.