Open georgemccabe opened 3 years ago
Update: When differences are found, the new output file, old truth file, and if applicable a difference file are added to an artifact with a name that starts with "diff" that can be downloaded to investigate closer.
Improvements to the process to create Conda environments to use in the use case tests, as suggested by Bill Little from the UK MetOffice:
Notes from @JohnHalleyGotway from PR review #810:
When differences are detected, add the files from the reference "truth" branch to the artifact created for that pull request GHA. That'll make it really easy for the PR reviewer to investigate the diffs.
Can we make the docker data volumes more self-describing? If possible, add a "/README" file that lists info like the creation date, source branch or SHA. There's potential to easily lose track of what data volumes where created by what version of the code and when.
Recommend mechanism to list files that should be EXCLUDED from the diffing logic. Could be as simple as a text file listing files to be skipped. I'm sure this will come up and be useful.
Describe the Enhancement
See above
Time Estimate
Estimate the amount of work required here. Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
feature_<Issue Number>_<Description>
feature <Issue Number> <Description>