dtcenter / METviewer

Tool that creates plots using MET verification statistics output and the R statistical package
http://www.dtcenter.org/met/metviewer/
Apache License 2.0
14 stars 1 forks source link

Issue #517 Added new columns for the VCNT, VL1L2, VAL1L2, and ECNT li… #544

Closed bikegeek closed 2 months ago

bikegeek commented 2 months ago

…netypes

Pull Request Testing

Pull Request Checklist

See the METplus Workflow for details.

michelleharrold commented 2 months ago

@bikegeek -- I reviewed the PR, and everything I looked at looks good!

Before approving, do we need to be concerned with the failed SonarQube scan (related Duplicated Lines (%) on New Code)? If not, I will approve ASAP!

jprestop commented 2 months ago

@michelleharrold and @bikegeek Let's discuss "failed SonarQube scan (related Duplicated Lines (%) on New Code)" at the meeting today. @bikegeek We'll be sure to update the notes with our discussion in case you're unable to make the meeting.

michelleharrold commented 2 months ago

Based on the discussion in the meeting, we do not need to address the code duplication issues, so we are good to go!

michelleharrold commented 2 months ago

@bikegeek and @jprestop -- I do not have write access, so my review is not sufficient! Can I be allowed or write access (if not, totally fine, but then we will need another reviewer!)

jprestop commented 2 months ago

@michelleharrold Ah! Thanks for letting us know. Please refresh and give it another try.