Open venitahagerty opened 5 years ago
We have merged the dev branch into the feature _82 branch and pushed the feature branch. Questions: 1) Do we push into the dev branch or does Tatiana? 2) Do we merge feature 89 into our code and push? 3) We have test errors that we do not understand. I attached an output file. 4) We still need updated test data feature82-errors.txt
in order to deal with the group by clause in some mysql statements we added a small piece of code to most of the select statement builders that iterates through the select fields and creates a group by clause that has all of the select fields in it. We had to do this to (I think) six pieces of code. I tried to put a comment with "RTP" in it. Here is an example... // RTP if it is in the select I think it MUST be in the GROUP_BY for (String elem : selectList.split(",\n")) { // space in the elem probably mean aggregation or function? elem = elem.trim().replaceAll("h\.", ""); if (!(strGroupBy.contains(elem)) && !elem.contains(" ")) { if (groups.length > 0) { strGroupBy += " ,"; } strGroupBy += elem; } } strGroupBy += ", object_id, object_cat";
After adding the extra group by elements I am seeing these warnings from the allTestRunner... ==== Start Rscript error ==== Warning messages: 1: In eventEqualize(fPlot, strIndyVar, listIndyVal, listSeries1Val, : WARNING: eventEqualize() detected non-unique events for A3AFWAOCv3.5.1_d01 using [fcst_valid_beg,fcst_lead)] 2: In eventEqualize(fPlot, strIndyVar, listIndyVal, listSeries1Val, : WARNING: eventEqualize() detected non-unique events for A3NoahMPv3.5.1_d01 using [fcst_valid_beg,fcst_lead)] ==== End Rscript error ====
I do not know if these are related or expected error messages.
GSD has added classes for Couchbase. Added autotest code. Refactored the db package. This issue is to track merging these changes into the production code.