search

dtch1997 / sae-eap

Edge attribution patching with SAEs
1 stars 0 forks source link

feat: pruning, evaluation #11

Closed dtch1997 closed 3 months ago

dtch1997 commented 3 months ago

Roadmap

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

This update enhances the greater_than.ipynb notebook by introducing new setup and error-handling procedures, along with significant restructuring. Key improvements involve splitting functionality into explicit functions within the EAP-IG model's ecosystem, incorporating caching and ablation capabilities, refining graph node and edge management, and expanding testing coverage. Overall, these changes boost the robustness, usability, and extensibility of the EAP-IG model and its associated components.

Changes

Files/Modules Change Summary
examples/eap_ig/greater_than.ipynb Added setup section, renamed sections, added error handling, updated code execution count, added new functions and cell
sae_eap/attribute.py Modified get_cache_hook default parameter, updated hook assignments for caching, added assertion, moved score addition logic
sae_eap/graph/build.py Renamed node construction functions, added build_attn_nodes, refactored build_layer_attn_nodes
sae_eap/prune.py Introduced new pruning classes and methods, added utility functions, enhanced edge/node pruning logic
sae_eap/ablate.py Added functions for edge ablation hooks, subgraph checks, and ablation input settings
sae_eap/cache.py Added caching tensor functionalities, CacheDict, and cache setter hooks
sae_eap/core/types.py Renamed hook types, added TLForwardHookFn, TLBackwardHookFn, ForwardHook, and BackwardHook
sae_eap/data/handler.py BatchHandler.get_logits method accepts InputType literal, added __repr__ to SinglePromptHandler
sae_eap/data/ioi.py Introduced make_ioi_single function
sae_eap/graph/init.py Added TensorNode, SrcNode, DestNode, and TensorEdge classes
sae_eap/graph/edge.py TensorEdge got new properties src and dest
sae_eap/graph/graph.py Added has_node and has_edge methods
sae_eap/graph/node.py Enhanced activation handling methods in TensorNode and other node types
sae_eap/runner.py Introduced run_attribution and run_ablation functions
tests/integration/attribute/test_attribute.py Removed test_attribute function
.../runner/test_run_ablate.py Added functions for pruner pipeline creation and ablation testing
.../runner/test_run_attribute.py Introduced test_attribute function with attribution process testing

Poem

Mid the nodes and edges thrives a graph anew, Pruned and cached, its circuits true. EAP-IG stands tall, in CUDA's embrace, Handling errors with a quartz-like grace. With hooks and tensors, pruners align, In the realm of models, they brightly shine.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.