feat!: make compatible with `bevy@~0.14`

waynevanson commented 2 months ago

I got close but not close enough, using the branch https://github.com/mkrasnitski/pixels from the PR https://github.com/parasyte/pixels/pull/391 via the patches in cargo.

Blocked by https://github.com/parasyte/pixels/pull/391
Closes #22
Pixels added a lifetime to the struct so we need to add one too. Not sure if <'win: 'static> is the way to go. Bevy query types want 'static but figured allowing our own lifetime bound by static is better than just static.

I can't figure out the error in src/system.rs. It says that the window we get on line 33 doesn't have the trait HasWindowHandle. I believe it should be on there because we've added the feature rwh_06.

Feel free to add to or change this as you wish!

parasyte commented 1 month ago

FWIW, https://github.com/parasyte/pixels/pull/391 was merged today.

dtcristo commented 1 month ago

FWIW, parasyte/pixels#391 was merged today.

Thanks @parasyte! I'll look at getting bevy_pixels working with bevy 0.14 and pixels 0.14.

parasyte commented 1 month ago

I haven't yet published a pixels release that supports wgpu 0.19, but I will be glad to if it will unblock this PR.

dtcristo commented 1 month ago

I haven't yet published a pixels release that supports wgpu 0.19, but I will be glad to if it will unblock this PR.

@parasyte Ahh, so the new release of pixels 0.14 just bumps to wgpu 0.17 while it's the PR you mentioned that brings you to wgpu 0.19 with support for raw-window-handle 0.6 (yet to be included in a release)? I just noticed pixels 0.14 was just released and assumed it was included.

It would be nice to get this into a release, but no rush. More than happy to wait until those changes have been battle tested first.

dtcristo / bevy_pixels

feat!: make compatible with `bevy@~0.14` #23