search

dtcrout / spotitude

Yet another Spotify user analytics visualizer
MIT License
19 stars 7 forks source link

added pipenv to Makefile and Readme #19

Closed thinkgruen closed 5 years ago

thinkgruen commented 5 years ago

Hey there, I wanted to contribute a little to #17 by making sure all is running in a virtual environment. If you feel that the changes are unclear or want it differently, let me know 😃

I could also include a part about installing the dependencies globally, but maybe that would be overcomplicating it too much.

dtcrout commented 5 years ago

Would it be possible to use virtualenv instead as it's already bundled with Python 3? That way we don't need to include another dependancy.

thinkgruen commented 5 years ago

i tweaked the Makefile accordingly to require a (built-in) virtual environment for tests and clean. If it doesn't exist, it will be created from scratch. This should also make sure that the steps can be done out of order.

I will later update the readme, too, and update the PR.

dtcrout commented 5 years ago

Thanks for using venv!

My original concern with using pipenv was that we would need to install it using another package manager. By using venv, the user just needs Python 3.